EMBA firmware report

In /logs/firmware/unblob_extracted/firmware_extract/11108416-13869836.lzma_extract/lzma.uncompressed_extract/3761304-11775640.cpio_portable_ascii_extract/usr/share/udhcpc/default.script line 14:

		/sbin/ifconfig $interface up

                               ^--------^ SC2154 (warning): interface is referenced but not assigned.

                               ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

		/sbin/ifconfig "$interface" up

In /logs/firmware/unblob_extracted/firmware_extract/11108416-13869836.lzma_extract/lzma.uncompressed_extract/3761304-11775640.cpio_portable_ascii_extract/usr/share/udhcpc/default.script line 15:

		/sbin/ifconfig $interface 0.0.0.0

                               ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

		/sbin/ifconfig "$interface" 0.0.0.0

In /logs/firmware/unblob_extracted/firmware_extract/11108416-13869836.lzma_extract/lzma.uncompressed_extract/3761304-11775640.cpio_portable_ascii_extract/usr/share/udhcpc/default.script line 20:

		grep -vE "# $interface\$" $RESOLV_CONF > $TMPFILE

                                                         ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

		grep -vE "# $interface\$" $RESOLV_CONF > "$TMPFILE"

In /logs/firmware/unblob_extracted/firmware_extract/11108416-13869836.lzma_extract/lzma.uncompressed_extract/3761304-11775640.cpio_portable_ascii_extract/usr/share/udhcpc/default.script line 21:

		cat $TMPFILE > $RESOLV_CONF

                    ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

		cat "$TMPFILE" > $RESOLV_CONF

In /logs/firmware/unblob_extracted/firmware_extract/11108416-13869836.lzma_extract/lzma.uncompressed_extract/3761304-11775640.cpio_portable_ascii_extract/usr/share/udhcpc/default.script line 22:

		rm -f $TMPFILE

                      ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

		rm -f "$TMPFILE"

In /logs/firmware/unblob_extracted/firmware_extract/11108416-13869836.lzma_extract/lzma.uncompressed_extract/3761304-11775640.cpio_portable_ascii_extract/usr/share/udhcpc/default.script line 25:

			/usr/sbin/avahi-autoipd -k $interface

                                                   ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

			/usr/sbin/avahi-autoipd -k "$interface"

In /logs/firmware/unblob_extracted/firmware_extract/11108416-13869836.lzma_extract/lzma.uncompressed_extract/3761304-11775640.cpio_portable_ascii_extract/usr/share/udhcpc/default.script line 31:

			/usr/sbin/avahi-autoipd -wD $interface --no-chroot

                                                    ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

			/usr/sbin/avahi-autoipd -wD "$interface" --no-chroot

In /logs/firmware/unblob_extracted/firmware_extract/11108416-13869836.lzma_extract/lzma.uncompressed_extract/3761304-11775640.cpio_portable_ascii_extract/usr/share/udhcpc/default.script line 37:

			/usr/sbin/avahi-autoipd -k $interface

                                                   ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

			/usr/sbin/avahi-autoipd -k "$interface"

In /logs/firmware/unblob_extracted/firmware_extract/11108416-13869836.lzma_extract/lzma.uncompressed_extract/3761304-11775640.cpio_portable_ascii_extract/usr/share/udhcpc/default.script line 39:

		/sbin/ifconfig $interface $ip $BROADCAST $NETMASK

                               ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

                                          ^-^ SC2154 (warning): ip is referenced but not assigned.

                                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

                                              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

                                                         ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

		/sbin/ifconfig "$interface" "$ip" "$BROADCAST" "$NETMASK"

In /logs/firmware/unblob_extracted/firmware_extract/11108416-13869836.lzma_extract/lzma.uncompressed_extract/3761304-11775640.cpio_portable_ascii_extract/usr/share/udhcpc/default.script line 43:

			while route del default gw 0.0.0.0 dev $interface 2> /dev/null; do

                                                               ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

			while route del default gw 0.0.0.0 dev "$interface" 2> /dev/null; do

In /logs/firmware/unblob_extracted/firmware_extract/11108416-13869836.lzma_extract/lzma.uncompressed_extract/3761304-11775640.cpio_portable_ascii_extract/usr/share/udhcpc/default.script line 48:

				route add default gw $i dev $interface

                                                     ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

                                                            ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

				route add default gw "$i" dev "$interface"

In /logs/firmware/unblob_extracted/firmware_extract/11108416-13869836.lzma_extract/lzma.uncompressed_extract/3761304-11775640.cpio_portable_ascii_extract/usr/share/udhcpc/default.script line 55:

		grep -vE "# $interface\$" $RESOLV_CONF > $TMPFILE

                                                         ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

		grep -vE "# $interface\$" $RESOLV_CONF > "$TMPFILE"

In /logs/firmware/unblob_extracted/firmware_extract/11108416-13869836.lzma_extract/lzma.uncompressed_extract/3761304-11775640.cpio_portable_ascii_extract/usr/share/udhcpc/default.script line 56:

		cat $TMPFILE > $RESOLV_CONF

                    ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

		cat "$TMPFILE" > $RESOLV_CONF

In /logs/firmware/unblob_extracted/firmware_extract/11108416-13869836.lzma_extract/lzma.uncompressed_extract/3761304-11775640.cpio_portable_ascii_extract/usr/share/udhcpc/default.script line 57:

		rm -f $TMPFILE

                      ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

		rm -f "$TMPFILE"

In /logs/firmware/unblob_extracted/firmware_extract/11108416-13869836.lzma_extract/lzma.uncompressed_extract/3761304-11775640.cpio_portable_ascii_extract/usr/share/udhcpc/default.script line 69:

		for i in $dns ; do

                         ^--^ SC2154 (warning): dns is referenced but not assigned.

In /logs/firmware/unblob_extracted/firmware_extract/11108416-13869836.lzma_extract/lzma.uncompressed_extract/3761304-11775640.cpio_portable_ascii_extract/usr/share/udhcpc/default.script line 70:

			echo adding dns $i

                                        ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

			echo adding dns "$i"

In /logs/firmware/unblob_extracted/firmware_extract/11108416-13869836.lzma_extract/lzma.uncompressed_extract/3761304-11775640.cpio_portable_ascii_extract/usr/share/udhcpc/default.script line 78:

    [ -f "${hook}" -a -x "${hook}" ] || continue

                   ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.

For more information:

  https://www.shellcheck.net/wiki/SC2154 -- dns is referenced but not assigned.

  https://www.shellcheck.net/wiki/SC2166 -- Prefer [ p ] && [ q ] as [ p -a q...

  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...