In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 17:
if test "${string#*$substring}" != "$string"
^--------^ SC2295 (info): Expansions inside ${..} need to be quoted separately, otherwise they match as patterns.
Did you mean:
if test "${string#*"$substring"}" != "$string"
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 26:
ready_msg="{\"method\":\"_internal.helper_ready\"}"
^-- SC2089 (warning): Quotes/backslashes will be treated literally. Rewrite using set/"$@" or functions.
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 27:
echo $ready_msg
^--------^ SC2090 (warning): Quotes/backslashes in this variable will not be respected.
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 38:
if [ -e $wificonf_file ]; then
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -e "$wificonf_file" ]; then
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 41:
WIFI_SSID=`cat $wificonf_file | grep ssid`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
WIFI_SSID=$(cat "$wificonf_file" | grep ssid)
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 46:
REQ_WIFI_CONF_STATUS_RESPONSE="{\"method\":\"_internal.res_wifi_conf_status\",\"params\":0}"
^-- SC2089 (warning): Quotes/backslashes will be treated literally. Rewrite using set/"$@" or functions.
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 57:
dinfo_did=`readFile $dinfo_file 'did='`
^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
dinfo_did=$(readFile "$dinfo_file" 'did=')
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 60:
dinfo_key=`readFile $dinfo_file 'key='`
^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
dinfo_key=$(readFile "$dinfo_file" 'key=')
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 63:
dinfo_vendor=`readFile $dinfo_file 'vendor='`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
dinfo_vendor=$(readFile "$dinfo_file" 'vendor=')
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 66:
dinfo_mac=`readFile $dinfo_file 'mac='`
^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
dinfo_mac=$(readFile "$dinfo_file" 'mac=')
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 69:
dinfo_model=`readFile $dinfo_file 'model='`
^-----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
dinfo_model=$(readFile "$dinfo_file" 'model=')
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 71:
RESPONSE_DINFO="{\"method\":\"_internal.response_dinfo\",\"params\":{"
^-- SC2089 (warning): Quotes/backslashes will be treated literally. Rewrite using set/"$@" or functions.
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 72:
if [ x$dinfo_did != x ]; then
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ x"$dinfo_did" != x ]; then
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 75:
echo "did:"$dinfo_did
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "did:""$dinfo_did"
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 77:
if [ x$dinfo_key != x ]; then
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ x"$dinfo_key" != x ]; then
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 80:
echo "key:"$dinfo_key
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "key:""$dinfo_key"
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 82:
if [ x$dinfo_vendor != x ]; then
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ x"$dinfo_vendor" != x ]; then
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 85:
echo "vendor:"$vendor
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "vendor:""$vendor"
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 87:
if [ x$dinfo_mac != x ]; then
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ x"$dinfo_mac" != x ]; then
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 90:
echo "mac:"$mac
^--^ SC2154 (warning): mac is referenced but not assigned.
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "mac:""$mac"
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 92:
if [ x$dinfo_model != x ]; then
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ x"$dinfo_model" != x ]; then
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 95:
echo "model:"$model
^----^ SC2154 (warning): model is referenced but not assigned.
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "model:""$model"
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 109:
if [ ! -e ${dtoken_dir}/wifi.conf ]; then
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ ! -e "${dtoken_dir}"/wifi.conf ]; then
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 110:
rm -f ${dtoken_file}
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "${dtoken_file}"
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 113:
if [ -e ${dtoken_file} ]; then
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -e "${dtoken_file}" ]; then
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 114:
dtoken_token=`cat ${dtoken_file}`
^------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
dtoken_token=$(cat "${dtoken_file}")
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 116:
echo ${dtoken_token} > ${dtoken_file}
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "${dtoken_token}" > "${dtoken_file}"
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 119:
RESPONSE_DTOKEN="{\"method\":\"_internal.response_dtoken\",\"params\":\"${dtoken_token}\"}"
^-- SC2089 (warning): Quotes/backslashes will be treated literally. Rewrite using set/"$@" or functions.
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 124:
BUF=`$MIIO_RECV_LINE`
^---------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
BUF=$($MIIO_RECV_LINE)
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 125:
if contains $BUF "_internal.info"; then
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if contains "$BUF" "_internal.info"; then
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 126:
STRING=`wpa_cli status`
^--------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
STRING=$(wpa_cli status)
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 138:
ssid=`readFile /etc/config/.wifissid`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
ssid=$(readFile /etc/config/.wifissid)
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 142:
bssid=`echo ${bssid} | cut -d ' ' -f 1 | tr '[:lower:]' '[:upper:]'`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
bssid=$(echo "${bssid}" | cut -d ' ' -f 1 | tr '[:lower:]' '[:upper:]')
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 146:
ip=`echo ${ip} | cut -d ' ' -f 1`
^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
ip=$(echo "${ip}" | cut -d ' ' -f 1)
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 149:
STRING=`ifconfig ${ifname}`
^------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
STRING=$(ifconfig "${ifname}")
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 152:
netmask=`echo ${netmask} | cut -d ' ' -f 1`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
netmask=$(echo "${netmask}" | cut -d ' ' -f 1)
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 155:
gw=`route -n|grep 'UG'|tr -s ' ' | cut -f 2 -d ' '`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
gw=$(route -n|grep 'UG'|tr -s ' ' | cut -f 2 -d ' ')
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 161:
vendor=`readFile /etc/miio/device.conf 'vendor='`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
vendor=$(readFile /etc/miio/device.conf 'vendor=')
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 162:
sw_version=`readFile /etc/os-release 'ISA_VERSION='`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
sw_version=$(readFile /etc/os-release 'ISA_VERSION=')
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 164:
if [ -z $sw_version ]; then
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -z "$sw_version" ]; then
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 168:
msg="{\"method\":\"_internal.info\",\"partner_id\":\"\",\"params\":{\
^-- SC2089 (warning): Quotes/backslashes will be treated literally. Rewrite using set/"$@" or functions.
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 177:
echo $msg
^--^ SC2090 (warning): Quotes/backslashes in this variable will not be respected.
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$msg"
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 179:
elif contains $BUF "_internal.req_wifi_conf_status"; then
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
elif contains "$BUF" "_internal.req_wifi_conf_status"; then
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 181:
req_wifi_conf_status $BUF
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
req_wifi_conf_status "$BUF"
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 182:
echo $REQ_WIFI_CONF_STATUS_RESPONSE
^----------------------------^ SC2090 (warning): Quotes/backslashes in this variable will not be respected.
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 184:
elif contains $BUF "_internal.wifi_start"; then
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
elif contains "$BUF" "_internal.wifi_start"; then
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 197:
let RETRY=$RETRY+1
^----------------^ SC3039 (warning): In POSIX sh, 'let' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 203:
msg="{\"method\":\"_internal.wifi_connected\"}"
^-- SC2089 (warning): Quotes/backslashes will be treated literally. Rewrite using set/"$@" or functions.
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 204:
echo $msg
^--^ SC2090 (warning): Quotes/backslashes in this variable will not be respected.
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 207:
rm $wificonf_file2
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm "$wificonf_file2"
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 211:
msg="{\"method\":\"local.status\",\"params\":\"wifi_ap_mode_2\"}"
^-- SC2089 (warning): Quotes/backslashes will be treated literally. Rewrite using set/"$@" or functions.
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 212:
echo $msg
^--^ SC2090 (warning): Quotes/backslashes in this variable will not be respected.
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 215:
elif contains $BUF "_internal.request_dinfo"; then
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
elif contains "$BUF" "_internal.request_dinfo"; then
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 217:
request_dinfo $BUF
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
request_dinfo "$BUF"
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 218:
echo $RESPONSE_DINFO
^-------------^ SC2090 (warning): Quotes/backslashes in this variable will not be respected.
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$RESPONSE_DINFO"
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 220:
elif contains $BUF "_internal.request_dtoken"; then
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
elif contains "$BUF" "_internal.request_dtoken"; then
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 222:
request_dtoken $BUF
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
request_dtoken "$BUF"
In /logs/firmware/unblob_extracted/firmware_extract/6225984-11075644.jffs2_new_extract/etc/miio_client/miio_client_helper_nomqtt.sh line 223:
echo $RESPONSE_DTOKEN
^--------------^ SC2090 (warning): Quotes/backslashes in this variable will not be respected.
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$RESPONSE_DTOKEN"
For more information:
https://www.shellcheck.net/wiki/SC2089 -- Quotes/backslashes will be treate...
https://www.shellcheck.net/wiki/SC2090 -- Quotes/backslashes in this variab...
https://www.shellcheck.net/wiki/SC2154 -- mac is referenced but not assigned.
