In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 3:
. /lib/functions.sh
^---------------^ SC1091 (info): Not following: /lib/functions.sh was not specified as input (see shellcheck -x).
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 4:
. /lib/functions/system.sh
^----------------------^ SC1091 (info): Not following: /lib/functions/system.sh was not specified as input (see shellcheck -x).
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 31:
/bin/mount | grep "on $1 type" 2>&- 1>&- || /bin/mount -o bind $1 $1
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
/bin/mount | grep "on $1 type" 2>&- 1>&- || /bin/mount -o bind "$1" "$1"
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 32:
mkdir -p $1$2 $1/proc $1/sys $1/dev $1/tmp $1/overlay && \
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mkdir -p "$1""$2" "$1"/proc "$1"/sys "$1"/dev "$1"/tmp "$1"/overlay && \
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 33:
/bin/mount -o noatime,move /proc $1/proc && \
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
Did you mean:
/bin/mount -o noatime,move /proc "$1"/proc && \
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 34:
pivot_root $1 $1$2 || {
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
pivot_root "$1" "$1""$2" || {
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 35:
/bin/umount -l $1 $1
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
/bin/umount -l "$1" "$1"
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 39:
/bin/mount -o noatime,move $2/sys /sys
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
/bin/mount -o noatime,move "$2"/sys /sys
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 40:
/bin/mount -o noatime,move $2/dev /dev
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
/bin/mount -o noatime,move "$2"/dev /dev
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 41:
/bin/mount -o noatime,move $2/tmp /tmp
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
/bin/mount -o noatime,move "$2"/tmp /tmp
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 42:
/bin/mount -o noatime,move $2/overlay /overlay 2>&-
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
/bin/mount -o noatime,move "$2"/overlay /overlay 2>&-
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 59:
local file="$(which "$binary" 2>/dev/null)"
^--------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^--^ SC2155 (warning): Declare and assign separately to avoid masking return values.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 62:
install_file /etc/resolv.conf /lib/*.sh /lib/functions/*.sh /lib/upgrade/*.sh $RAMFS_COPY_DATA
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
install_file /etc/resolv.conf /lib/*.sh /lib/functions/*.sh /lib/upgrade/*.sh "$RAMFS_COPY_DATA"
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 64:
[ -L "/lib64" ] && ln -s /lib $RAM_ROOT/lib64
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -L "/lib64" ] && ln -s /lib "$RAM_ROOT"/lib64
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 66:
supivot $RAM_ROOT /mnt || {
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
supivot "$RAM_ROOT" /mnt || {
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 81:
local loop_limit=10
^--------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 83:
local sig="${1:-TERM}"
^-------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 84:
local loop="${2:-0}"
^--------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 85:
local run=true
^-------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 86:
local stat
^--------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 87:
local proc_ppid=$(cut -d' ' -f4 /proc/$$/stat)
^-------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
^-----------------------------^ SC2046 (warning): Quote this to prevent word splitting.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 89:
echo -n "Sending $sig to remaining processes ... "
^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 96:
local pid name state ppid rest
^----------------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 97:
read pid name state ppid rest < $stat
^--^ SC2162 (info): read without -r will mangle backslashes.
^---^ SC2034 (warning): state appears unused. Verify use (or export if used externally).
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
read pid name state ppid rest < "$stat"
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 101:
[ $pid -ne 1 -a $pid -ne $proc_ppid -a $pid -ne $$ -a $ppid -ne $$ ] || continue
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$pid" -ne 1 -a "$pid" -ne "$proc_ppid" -a "$pid" -ne $$ -a "$ppid" -ne $$ ] || continue
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 103:
local cmdline
^-----------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 104:
read cmdline < /proc/$pid/cmdline
^--^ SC2162 (info): read without -r will mangle backslashes.
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
read cmdline < /proc/"$pid"/cmdline
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 109:
echo -n "$name "
^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 110:
kill -$sig $pid 2>/dev/null
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
kill -"$sig" "$pid" 2>/dev/null
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 112:
[ $loop -eq 1 ] && run=true
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$loop" -eq 1 ] && run=true
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 115:
let loop_limit--
^--------------^ SC3039 (warning): In POSIX sh, 'let' is undefined.
^-- SC3018 (warning): In POSIX sh, -- is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/upgrade/stage2 line 142:
IS_PRE_UPGRADE=
^------------^ SC2034 (warning): IS_PRE_UPGRADE appears unused. Verify use (or export if used externally).
For more information:
https://www.shellcheck.net/wiki/SC2034 -- IS_PRE_UPGRADE appears unused. Ve...
https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...