In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 4:
START=60
^---^ SC2034 (warning): START appears unused. Verify use (or export if used externally).
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 5:
USE_PROCD=1
^-------^ SC2034 (warning): USE_PROCD appears unused. Verify use (or export if used externally).
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 8:
config_get samba_iface $1 interface "loopback lan"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
config_get samba_iface "$1" interface "loopback lan"
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 11:
local interfaces=$(
^--------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
^-- SC2046 (warning): Quote this to prevent word splitting.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 12:
. /lib/functions/network.sh
^-----------------------^ SC1091 (info): Not following: /lib/functions/network.sh was not specified as input (see shellcheck -x).
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 14:
local net
^-------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 15:
for net in $samba_iface; do
^----------^ SC2154 (warning): samba_iface is referenced but not assigned.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 16:
local device
^----------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 17:
network_is_up $net || continue
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
network_is_up "$net" || continue
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 19:
echo -n "${device:-$net} "
^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 23:
local name workgroup description charset
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 24:
local hostname="$(uci_get system.@system[0].hostname)"
^------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 26:
config_get name $1 name "${hostname:-OpenWrt}"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
config_get name "$1" name "${hostname:-OpenWrt}"
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 27:
config_get workgroup $1 workgroup "${hostname:-OpenWrt}"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
config_get workgroup "$1" workgroup "${hostname:-OpenWrt}"
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 28:
config_get description $1 description "Samba on ${hostname:-OpenWrt}"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
config_get description "$1" description "Samba on ${hostname:-OpenWrt}"
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 29:
config_get charset $1 charset "UTF-8"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
config_get charset "$1" charset "UTF-8"
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 39:
local homes
^---------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 40:
config_get_bool homes $1 homes 0
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
config_get_bool homes "$1" homes 0
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 41:
[ $homes -gt 0 ] && {
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$homes" -gt 0 ] && {
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 56:
local name
^--------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 57:
local path
^--------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 58:
local users
^---------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 59:
local read_only
^-------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 60:
local guest_ok
^------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 61:
local create_mask
^---------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 62:
local dir_mask
^------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 63:
local browseable
^--------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 65:
config_get name $1 name
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
config_get name "$1" name
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 66:
config_get path $1 path
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
config_get path "$1" path
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 67:
config_get users $1 users
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
config_get users "$1" users
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 68:
config_get read_only $1 read_only
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
config_get read_only "$1" read_only
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 69:
config_get guest_ok $1 guest_ok
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
config_get guest_ok "$1" guest_ok
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 70:
config_get create_mask $1 create_mask
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
config_get create_mask "$1" create_mask
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 71:
config_get dir_mask $1 dir_mask
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
config_get dir_mask "$1" dir_mask
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 72:
config_get browseable $1 browseable
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
config_get browseable "$1" browseable
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 74:
[ -z "$name" -o -z "$path" ] && return
^-- SC2166 (warning): Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 76:
echo -e "\n[$name]\n\tpath = $path" >> /var/etc/smb.conf
^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 77:
[ -n "$users" ] && echo -e "\tvalid users = $users" >> /var/etc/smb.conf
^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 78:
[ -n "$read_only" ] && echo -e "\tread only = $read_only" >> /var/etc/smb.conf
^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 79:
[ -n "$guest_ok" ] && echo -e "\tguest ok = $guest_ok" >> /var/etc/smb.conf
^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 80:
[ -n "$create_mask" ] && echo -e "\tcreate mask = $create_mask" >> /var/etc/smb.conf
^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 81:
[ -n "$dir_mask" ] && echo -e "\tdirectory mask = $dir_mask" >> /var/etc/smb.conf
^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 82:
[ -n "$browseable" ] && echo -e "\tbrowseable = $browseable" >> /var/etc/smb.conf
^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 96:
local i
^-----^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/samba line 98:
procd_add_reload_interface_trigger $i
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
procd_add_reload_interface_trigger "$i"
For more information:
https://www.shellcheck.net/wiki/SC2034 -- START appears unused. Verify use ...
https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
https://www.shellcheck.net/wiki/SC2154 -- samba_iface is referenced but not...
