In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 3:
START=91 # after svm
^---^ SC2034 (warning): START appears unused. Verify use (or export if used externally).
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 4:
PIDFILE=/var/run/mqtt-service.pid
^-----^ SC2034 (warning): PIDFILE appears unused. Verify use (or export if used externally).
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 6:
prefix=/usr
^----^ SC2034 (warning): prefix appears unused. Verify use (or export if used externally).
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 18:
while test $try -lt 40 ; do
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
while test "$try" -lt 40 ; do
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 35:
echo -n .
^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 36:
try=`expr $try + 1`
^-------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]].
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
try=$(expr "$try" + 1)
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 43:
while test $try -lt 40 ; do
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
while test "$try" -lt 40 ; do
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 44:
if [ -n `pidof $1` ] ; then
^--------^ SC2070 (error): -n doesn't work with unquoted arguments. Quote or use [[ ]].
^--------^ SC2046 (warning): Quote this to prevent word splitting.
^--------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -n $(pidof "$1") ] ; then
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 48:
echo -n .
^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 49:
try=`expr $try + 1`
^-------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]].
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
try=$(expr "$try" + 1)
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 55:
echo -n "Starting mqtt-service "
^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 60:
if [ "$?" != 0 ] ; then
^--^ SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 78:
echo -n "Gracefully shutting down mqtt-service "
^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 86:
kill -INT `cat $mqtt_service_PID` || killall mqtt-service
^---------------------^ SC2046 (warning): Quote this to prevent word splitting.
^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
kill -INT $(cat $mqtt_service_PID) || killall mqtt-service
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 105:
PID=`cat $mqtt_service_PID`
^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
PID=$(cat $mqtt_service_PID)
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 106:
if ps | grep -w $PID | grep -qv grep; then
^-- SC2009 (info): Consider using pgrep instead of grepping ps output.
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if ps | grep -w "$PID" | grep -qv grep; then
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 114:
echo -n "Terminating mqtt-service "
^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 123:
kill -TERM `cat $mqtt_service_PID` || killall mqtt-service
^---------------------^ SC2046 (warning): Quote this to prevent word splitting.
^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
kill -TERM $(cat $mqtt_service_PID) || killall mqtt-service
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 129:
retval=1
^----^ SC2034 (warning): retval appears unused. Verify use (or export if used externally).
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 137:
for i in `seq $steps` ; do
^-^ SC2034 (warning): i appears unused. Verify use (or export if used externally).
^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
for i in $(seq "$steps") ; do
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 138:
echo -n .
^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/etc/init.d/mqtt-service line 144:
echo -n "Wait a while for other services to be ready "
^-- SC3037 (warning): In POSIX sh, echo flags are undefined.
For more information:
https://www.shellcheck.net/wiki/SC2070 -- -n doesn't work with unquoted arg...
https://www.shellcheck.net/wiki/SC2034 -- PIDFILE appears unused. Verify us...
https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
