In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/wifi/mac80211.sh line 6:
[ -d /sys/class/ieee80211/$phy ] && return
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -d /sys/class/ieee80211/"$phy" ] && return
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/wifi/mac80211.sh line 9:
local devpath
^-----------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/wifi/mac80211.sh line 12:
for phy in $(ls /sys/class/ieee80211 2>/dev/null); do
^-- SC2045 (error): Iterating over ls output is fragile. Use globs.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/wifi/mac80211.sh line 13:
case "$(readlink -f /sys/class/ieee80211/$phy/device)" in
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
case "$(readlink -f /sys/class/ieee80211/"$phy"/device)" in
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/wifi/mac80211.sh line 19:
local macaddr="$(config_get "$device" macaddr | tr 'A-Z' 'a-z')"
^-----------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values.
^---^ SC2019 (info): Use '[:upper:]' to support accents and foreign alphabets.
^---^ SC2018 (info): Use '[:lower:]' to support accents and foreign alphabets.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/wifi/mac80211.sh line 24:
[ "$macaddr" = "$(cat ${_phy}/macaddress)" ] || continue
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$macaddr" = "$(cat "${_phy}"/macaddress)" ] || continue
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/wifi/mac80211.sh line 34:
local device="$1"
^----------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/wifi/mac80211.sh line 38:
[ -n "$phy" -a -d "/sys/class/ieee80211/$phy" ] || {
^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/wifi/mac80211.sh line 46:
config_set "$device" macaddr "$(cat /sys/class/ieee80211/${phy}/macaddress)"
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
config_set "$device" macaddr "$(cat /sys/class/ieee80211/"${phy}"/macaddress)"
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/wifi/mac80211.sh line 67:
devidx=$(($devidx + 1))
^-----^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/wifi/mac80211.sh line 94:
if [ -x /usr/bin/readlink -a -h /sys/class/ieee80211/${dev} ]; then
^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -x /usr/bin/readlink -a -h /sys/class/ieee80211/"${dev}" ]; then
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/wifi/mac80211.sh line 95:
path="$(readlink -f /sys/class/ieee80211/${dev}/device)"
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
path="$(readlink -f /sys/class/ieee80211/"${dev}"/device)"
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/wifi/mac80211.sh line 106:
dev_id="set wireless.radio${devidx}.macaddr=$(cat /sys/class/ieee80211/${dev}/macaddress)"
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
dev_id="set wireless.radio${devidx}.macaddr=$(cat /sys/class/ieee80211/"${dev}"/macaddress)"
In /logs/firmware/unblob_extracted/firmware_extract/1568982-13971496.squashfs_v4_le_extract/lib/wifi/mac80211.sh line 127:
devidx=$(($devidx + 1))
^-----^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
For more information:
https://www.shellcheck.net/wiki/SC2045 -- Iterating over ls output is fragi...
https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
https://www.shellcheck.net/wiki/SC2166 -- Prefer [ p ] && [ q ] as [ p -a q...