In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/libexec/sa/sa1 line 19:
[ -r ${SYSCONFIG_DIR}/${SYSCONFIG_FILE} ] && . ${SYSCONFIG_DIR}/${SYSCONFIG_FILE}
^-- SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/libexec/sa/sa1 line 35:
cd ${ENDIR}
^---------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
Did you mean:
cd ${ENDIR} || exit
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/libexec/sa/sa1 line 45:
DATE=`date --date=yesterday +%Y%m%d`
^-----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
DATE=$(date --date=yesterday +%Y%m%d)
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/libexec/sa/sa1 line 47:
DATE=`date --date=yesterday +%d`
^-------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
DATE=$(date --date=yesterday +%d)
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/libexec/sa/sa1 line 54:
exec ${ENDIR}/sadc -F -L ${SADC_OPTIONS} -C "LINUX SLEEP MODE ($*)" ${SA_DIR}
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
exec ${ENDIR}/sadc -F -L "${SADC_OPTIONS}" -C "LINUX SLEEP MODE ($*)" "${SA_DIR}"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/libexec/sa/sa1 line 60:
exec ${ENDIR}/sadc -F -L ${SADC_OPTIONS} 1 1 ${SA_DIR}
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
exec ${ENDIR}/sadc -F -L "${SADC_OPTIONS}" 1 1 "${SA_DIR}"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/libexec/sa/sa1 line 62:
exec ${ENDIR}/sadc -F -L ${SADC_OPTIONS} $* ${SA_DIR}
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2048 (warning): Use "$@" (with quotes) to prevent whitespace problems.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
exec ${ENDIR}/sadc -F -L "${SADC_OPTIONS}" "$*" "${SA_DIR}"
For more information:
https://www.shellcheck.net/wiki/SC1090 -- ShellCheck can't follow non-const...
https://www.shellcheck.net/wiki/SC2048 -- Use "$@" (with quotes) to prevent...
https://www.shellcheck.net/wiki/SC2164 -- Use 'cd ... || exit' or 'cd ... |...
