In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 4:
. /lib/rcscripts/sh/error.sh
^------------------------^ SC1091 (info): Not following: /lib/rcscripts/sh/error.sh was not specified as input (see shellcheck -x).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 67:
Usage: $(basename $0) [-h] [<command>] [-f] [image_to_flash.bin]
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
Usage: $(basename "$0") [-h] [<command>] [-f] [image_to_flash.bin]
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 85:
echo "$2" > $GPIOMAPPATH/$1/value || \
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$2" > $GPIOMAPPATH/"$1"/value || \
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 90:
printf $PROBE_VALUE > $SERIAL_PROBE ||
^----------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 124:
printf $PROBE_VALUE > $DRIVER_BIND_FILE ||
^----------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 131:
printf $PROBE_VALUE > $DRIVER_UNBIND_FILE ||
^----------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 142:
if [ "$linked" == "linked" ]; then
^-- SC3014 (warning): In POSIX sh, == in place of = is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 183:
CURRENT_OPT=$(stm32flash -f -r - -b $1 -S 0x1FFF7800:4 $FLASHPORT 2>$ERROR_PATH)
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
CURRENT_OPT=$(stm32flash -f -r - -b "$1" -S 0x1FFF7800:4 $FLASHPORT 2>$ERROR_PATH)
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 184:
if [ "$CURRENT_OPT" = $(echo -ne $OPT_STR) ]; then
^------------------^ SC2046 (warning): Quote this to prevent word splitting.
^-^ SC3037 (warning): In POSIX sh, echo flags are undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 188:
information $ERROR
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
information "$ERROR"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 190:
echo -ne $OPT_STR | stm32flash -f -w - -b $1 -S 0x1FFF7800:4 $FLASHPORT
^-^ SC3037 (warning): In POSIX sh, echo flags are undefined.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo -ne $OPT_STR | stm32flash -f -w - -b "$1" -S 0x1FFF7800:4 $FLASHPORT
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 198:
information "Using baud rate =" $2
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
information "Using baud rate =" "$2"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 200:
dev_info=$(stm32flash -b $2 $FLASHPORT)
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
dev_info=$(stm32flash -b "$2" $FLASHPORT)
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 202:
if [ $? -ne 0 ]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 210:
check_and_set_option_bytes $2
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
check_and_set_option_bytes "$2"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 216:
stm32flash -v -w $1 -b $2 $FLASHPORT && information "Flashing OK"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
stm32flash -v -w "$1" -b "$2" $FLASHPORT && information "Flashing OK"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 230:
do_stmflash $1 230400 || \
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
do_stmflash "$1" 230400 || \
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 231:
do_stmflash $1 115200 || \
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
do_stmflash "$1" 115200 || \
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 232:
do_stmflash $1 57600 || \
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
do_stmflash "$1" 57600 || \
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 233:
do_stmflash $1 38400 || \
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
do_stmflash "$1" 38400 || \
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 234:
do_stmflash $1 9600 || \
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
do_stmflash "$1" 9600 || \
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 249:
local FILEPATH="$FWPATH/Axxx-io-coprocessor.bin"
^------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 250:
local FORCE_FLASH
^---------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 252:
if [ $# = 2 -a "$1" = "-f" ]; then
^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 270:
do_flash $FILEPATH
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
do_flash "$FILEPATH"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 274:
do_flash $FILEPATH
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
do_flash "$FILEPATH"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/sbin/mcu-ctl line 291:
flash_mcu $*
^-- SC2048 (warning): Use "$@" (with quotes) to prevent whitespace problems.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
flash_mcu "$*"
For more information:
https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
https://www.shellcheck.net/wiki/SC2048 -- Use "$@" (with quotes) to prevent...
https://www.shellcheck.net/wiki/SC2166 -- Prefer [ p ] && [ q ] as [ p -a q...
