In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 5:
. /usr/lib/addon-common
^-------------------^ SC1091 (info): Not following: /usr/lib/addon-common was not specified as input (see shellcheck -x).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 6:
. /usr/lib/addon-apache-config
^--------------------------^ SC1091 (info): Not following: /usr/lib/addon-apache-config was not specified as input (see shellcheck -x).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 10:
[ $# -le 3 ] && [ "$1" ] && [ "$2" ] || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 18:
OPKGNAME=$(get_package_name $1) || {
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
OPKGNAME=$(get_package_name "$1") || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 28:
FIRST_BOOT_MODE="$3"
^-------------^ SC2034 (warning): FIRST_BOOT_MODE appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 37:
fail_errorcode $ERR_INVALID_PKG_NAME "Failed to validate package name: $OPKGNAME"
^-------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
fail_errorcode "$ERR_INVALID_PKG_NAME" "Failed to validate package name: $OPKGNAME"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 39:
[ $result -eq $TRUE ] || fail_errorcode $ERR_INVALID_PKG_NAME "Package name $OPKGNAME contains illegal characters only " "[a-z0-9.+-] is allowed"
^-----^ SC2154 (warning): result is referenced but not assigned.
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$result" -eq "$TRUE" ] || fail_errorcode "$ERR_INVALID_PKG_NAME" "Package name $OPKGNAME contains illegal characters only " "[a-z0-9.+-] is allowed"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 61:
is_package_installed $OPKGNAME result || fail_errorcode $ERR_INSTALL_ERROR "Failed to check if Add-on package $OPKGNAME is installed"
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
is_package_installed "$OPKGNAME" result || fail_errorcode "$ERR_INSTALL_ERROR" "Failed to check if Add-on package $OPKGNAME is installed"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 63:
[ $result -eq $TRUE ] || fail_errorcode $ERR_ADDON_NOT_FOUND "Add-on $pkgname is not installed"
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2154 (warning): pkgname is referenced but not assigned.
Did you mean:
[ "$result" -eq "$TRUE" ] || fail_errorcode "$ERR_ADDON_NOT_FOUND" "Add-on $pkgname is not installed"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 65:
OPKGFILES=$($OPKG files $OPKGNAME | tail +2) || {
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
OPKGFILES=$($OPKG files "$OPKGNAME" | tail +2) || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 77:
local errorcode
^-------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 79:
rm -f $SERVICE_PATH/$OPKGNAME.service
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "$SERVICE_PATH"/"$OPKGNAME".service
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 80:
rm -f $WEB_ROOT$OPKGNAME
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "$WEB_ROOT""$OPKGNAME"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 81:
remove_apac_grant $OPKGNAME || :
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
remove_apac_grant "$OPKGNAME" || :
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 82:
remove_addon_configuration $OPKGNAME || :
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
remove_addon_configuration "$OPKGNAME" || :
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 92:
fail_errorcode $errorcode "$@"
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
fail_errorcode "$errorcode" "$@"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 100:
local manifest_chk schema_location
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 102:
local SCHEMAPATH="usr/share/addon/schema"
^--------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 105:
major=$(xmllint --xpath "string(//Manifest/@Major)" $manifest_chk) ||
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
major=$(xmllint --xpath "string(//Manifest/@Major)" "$manifest_chk") ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 106:
revert_and_fail $ERR_INSTALL_ERROR "Internal Error when parsing manifest version"
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_INSTALL_ERROR" "Internal Error when parsing manifest version"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 107:
minor=$(xmllint --xpath "string(//Manifest/@Minor)" $manifest_chk) ||
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
minor=$(xmllint --xpath "string(//Manifest/@Minor)" "$manifest_chk") ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 108:
revert_and_fail $ERR_INSTALL_ERROR "Internal Error when parsing manifest version"
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_INSTALL_ERROR" "Internal Error when parsing manifest version"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 110:
[ "$major" ] && [ "$minor" ] || revert_and_fail $ERR_INSTALL_ERROR "Schema version: Major or Minor is missing"
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$major" ] && [ "$minor" ] || revert_and_fail "$ERR_INSTALL_ERROR" "Schema version: Major or Minor is missing"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 112:
[ -d $SDKTARGETSYSROOT/$SCHEMAPATH/$major/$minor ] || {
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -d "$SDKTARGETSYSROOT"/$SCHEMAPATH/"$major"/"$minor" ] || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 113:
revert_and_fail $ERR_INSTALL_ERROR "Requested schema version not available"
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_INSTALL_ERROR" "Requested schema version not available"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 116:
schema_location=$SDKTARGETSYSROOT/$SCHEMAPATH/$major/$minor/unrestricted_manifest.xsd
^-------------^ SC2034 (warning): schema_location appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 118:
eval $2=\$schema_location
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$2"=\$schema_location
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 121:
get_schema_location $MANIFESTFILE SCHEMAFILE
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
get_schema_location "$MANIFESTFILE" SCHEMAFILE
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 133:
[ -d $SERVICE_PATH ] || {
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -d "$SERVICE_PATH" ] || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 141:
local f
^-----^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 150:
INSTALL_DIR=$(get_path $OPKGNAME) || {
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
INSTALL_DIR=$(get_path "$OPKGNAME") || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 165:
[ $1 ] || return 1
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$1" ] || return 1
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 167:
echo $MANIFEST | xmllint --xpath "$1" -
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$MANIFEST" | xmllint --xpath "$1" -
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 174:
MANIFEST=$(xmllint --schema $SCHEMAFILE $MANIFESTFILE) > /dev/null 2>&1 ||
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
MANIFEST=$(xmllint --schema "$SCHEMAFILE" "$MANIFESTFILE") > /dev/null 2>&1 ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 175:
revert_and_fail $ERR_MANIFEST "Invalid manifest"
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" "Invalid manifest"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 178:
revert_and_fail $ERR_MANIFEST "Internal error when trying to: get license"
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" "Internal error when trying to: get license"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 180:
[ -n "$license" ] || revert_and_fail $ERR_NO_LICENSE "No license in manifest"
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -n "$license" ] || revert_and_fail "$ERR_NO_LICENSE" "No license in manifest"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 184:
local busname tmp_busname count_iface m type i=0 m=0
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 188:
remove_apac_grant $OPKGNAME
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
remove_apac_grant "$OPKGNAME"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 191:
revert_and_fail $ERR_MANIFEST 'Fail to extract required data from manifest'
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" 'Fail to extract required data from manifest'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 199:
while [ $i -lt $count_iface ]; do
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
while [ $i -lt "$count_iface" ]; do
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 200:
i=$(($i + 1))
^-- SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 203:
revert_and_fail $ERR_MANIFEST 'Fail to extract requirement name from manifest'
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" 'Fail to extract requirement name from manifest'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 207:
revert_and_fail $ERR_MANIFEST 'Fail to extract required data from manifest'
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" 'Fail to extract required data from manifest'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 209:
while [ $m -lt $count_method ]; do
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
while [ $m -lt "$count_method" ]; do
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 210:
m=$(($m + 1))
^-- SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 212:
revert_and_fail $ERR_MANIFEST 'Fail to extract requirement name from manifest'
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" 'Fail to extract requirement name from manifest'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 217:
apac-update grant $OPKGNAME "$tmp_busname" > /dev/null 2>&1 ||
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
apac-update grant "$OPKGNAME" "$tmp_busname" > /dev/null 2>&1 ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 218:
revert_and_fail $ERR_API_GRANT_FAILED "Cannot grant access to $tmp_busname"
^-------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_API_GRANT_FAILED" "Cannot grant access to $tmp_busname"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 221:
enable_dbus_conf_for_cb $OPKGNAME
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
enable_dbus_conf_for_cb "$OPKGNAME"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 229:
local count groups type name i=0
^----------------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 234:
while [ $i -lt $count ]; do
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
while [ $i -lt "$count" ]; do
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 235:
i=$(($i + 1))
^-- SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 238:
[ -e /usr/share/addon/group/$name ] ||
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -e /usr/share/addon/group/"$name" ] ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 239:
revert_and_fail $ERR_INVALID_REQUIREMENT "$name is not a valid addon group"
^----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_INVALID_REQUIREMENT" "$name is not a valid addon group"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 251:
local count type busname user ownablebusname devmode_allowed_apis i=0
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
^--^ SC2034 (warning): type appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 254:
revert_and_fail $ERR_MANIFEST 'Fail to extract requirement data from manifest'
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" 'Fail to extract requirement data from manifest'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 258:
while [ $i -lt $count ]; do
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
while [ $i -lt "$count" ]; do
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 259:
i=$(($i + 1))
^-- SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 261:
revert_and_fail $ERR_MANIFEST 'Fail to extract requirement busname from manifest'
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" 'Fail to extract requirement busname from manifest'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 263:
revert_and_fail $ERR_MANIFEST 'Fail to extract minor version from DbusInterface'
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" 'Fail to extract minor version from DbusInterface'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 269:
is_api_available $busname $minor_version result user > /dev/null 2>&1 ||
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
is_api_available "$busname" "$minor_version" result user > /dev/null 2>&1 ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 270:
revert_and_fail $ERR_INSTALL_ERROR "Failed to check API $busname" "$minor_version is available"
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_INSTALL_ERROR" "Failed to check API $busname" "$minor_version is available"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 274:
if [ $SIGNED_PACKAGE -eq 0 ] && [ "$devmode_allowed_apis" ]; then
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$SIGNED_PACKAGE" -eq 0 ] && [ "$devmode_allowed_apis" ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 275:
is_api_allowed $devmode_allowed_apis "$DEVMODE_ALLOW_ALL_VALUE" ||
^-------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
is_api_allowed "$devmode_allowed_apis" "$DEVMODE_ALLOW_ALL_VALUE" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 276:
is_api_allowed $devmode_allowed_apis $busname ||
^-------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
is_api_allowed "$devmode_allowed_apis" "$busname" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 277:
revert_and_fail $ERR_INSTALL_ERROR "API $busname is not allowed in developer mode"
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_INSTALL_ERROR" "API $busname is not allowed in developer mode"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 282:
if [ $result -eq $TRUE ]; then
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$result" -eq "$TRUE" ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 283:
[ -z $user ] || {
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -z "$user" ] || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 288:
generate_dbus_conf_for_cb $OPKGNAME $user $busname
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
generate_dbus_conf_for_cb "$OPKGNAME" "$user" "$busname"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 292:
revert_and_fail $ERR_INVALID_REQUIREMENT "D-Bus name $busname ver $minor_version not available"
^----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_INVALID_REQUIREMENT" "D-Bus name $busname ver $minor_version not available"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 301:
local count linux_cap temp_caps i=0
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 302:
local cap_xpath=//Uses/Requires/LinuxCapability
^-------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 305:
revert_and_fail $ERR_MANIFEST "Invalid manifest"
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" "Invalid manifest"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 307:
while [ $i -lt $count ]; do
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
while [ $i -lt "$count" ]; do
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 308:
i=$(($i + 1))
^-- SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 309:
linux_cap=$(get_manifest_xpath "string($cap_xpath[$i])") ||
^-- SC1087 (error): Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 310:
revert_and_fail $ERR_MANIFEST "Invalid manifest"
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" "Invalid manifest"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 323:
local optionvalue optioncount temp optioncommand i=0
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 324:
local option_xpath=//Configuration/SystemdServiceFileOption
^----------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 327:
local servicefile="$1"
^---------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 332:
revert_and_fail $ERR_INSTALL_ERROR "Internal error"
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_INSTALL_ERROR" "Internal error"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 334:
while [ $i -lt $optioncount ]; do
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
while [ $i -lt "$optioncount" ]; do
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 335:
i=$(($i + 1))
^-- SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 336:
temp=$(get_manifest_xpath "string($option_xpath[$i])") ||
^-- SC1087 (error): Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 337:
revert_and_fail $ERR_MANIFEST "Invalid manifest"
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" "Invalid manifest"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 339:
revert_and_fail $ERR_MANIFEST "Empty SystemdServiceFileOption"
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" "Empty SystemdServiceFileOption"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 344:
optionvalue=$(echo $optionvalue | sed "s#\%ADDON_HOME\%#$addon_path#g")
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
optionvalue=$(echo "$optionvalue" | sed "s#\%ADDON_HOME\%#$addon_path#g")
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 346:
optionvalue=$(echo $optionvalue | sed "s#\%ADDON_BIN\%#$addon_bin_path#g")
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
optionvalue=$(echo "$optionvalue" | sed "s#\%ADDON_BIN\%#$addon_bin_path#g")
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 347:
echo "$optioncommand=$optionvalue" >> $servicefile
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$optioncommand=$optionvalue" >> "$servicefile"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 353:
local servicefile tmp_file
^------------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 354:
local start_execfile full_start_exec_path start_exec_option start_args
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
^------------^ SC2034 (warning): start_execfile appears unused. Verify use (or export if used externally).
^------------------^ SC2034 (warning): full_start_exec_path appears unused. Verify use (or export if used externally).
^---------------^ SC2034 (warning): start_exec_option appears unused. Verify use (or export if used externally).
^--------^ SC2034 (warning): start_args appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 355:
local stop_execfile full_stop_exec_path stop_exec_option stop_args
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
^-----------^ SC2034 (warning): stop_execfile appears unused. Verify use (or export if used externally).
^-----------------^ SC2034 (warning): full_stop_exec_path appears unused. Verify use (or export if used externally).
^--------------^ SC2034 (warning): stop_exec_option appears unused. Verify use (or export if used externally).
^-------^ SC2034 (warning): stop_args appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 356:
local remain_value remain_option
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
^----------^ SC2034 (warning): remain_value appears unused. Verify use (or export if used externally).
^-----------^ SC2034 (warning): remain_option appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 357:
local fcgis_count
^---------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 358:
local env_option
^--------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 359:
local cb_busname_option
^---------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 360:
local dropdownfolder dropdownfile tmpdropdownfile
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 365:
revert_and_fail $ERR_MANIFEST "Failed to get Fcgis"
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" "Failed to get Fcgis"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 366:
if [ $fcgis_count -eq 1 ]; then
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$fcgis_count" -eq 1 ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 377:
rm -f $tmp_file
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "$tmp_file"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 379:
if [ -f $servicefile ]; then
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -f "$servicefile" ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 383:
systemctl enable $OPKGNAME > /dev/null 2>&1 ||
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
systemctl enable "$OPKGNAME" > /dev/null 2>&1 ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 385:
systemctl stop $OPKGNAME > /dev/null 2>&1 ||
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
systemctl stop "$OPKGNAME" > /dev/null 2>&1 ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 387:
systemctl disable $OPKGNAME > /dev/null 2>&1 ||
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
systemctl disable "$OPKGNAME" > /dev/null 2>&1 ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 389:
remove_service $OPKGNAME
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
remove_service "$OPKGNAME"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 401:
Slice=extension-addon.slice" >$tmp_file || revert_and_fail $ERR_FILE_SYSTEM "Failed to create service for $OPKGNAME"
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
Slice=extension-addon.slice" >"$tmp_file" || revert_and_fail "$ERR_FILE_SYSTEM" "Failed to create service for $OPKGNAME"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 403:
extract_systemd_service_options $tmp_file
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
extract_systemd_service_options "$tmp_file"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 408:
WantedBy=multi-user.target" >>$tmp_file || revert_and_fail $ERR_FILE_SYSTEM "Failed to create service for $OPKGNAME"
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
WantedBy=multi-user.target" >>"$tmp_file" || revert_and_fail "$ERR_FILE_SYSTEM" "Failed to create service for $OPKGNAME"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 410:
chmod 644 $tmp_file
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod 644 "$tmp_file"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 412:
fsynced_write_or_cleanup $tmp_file $servicefile
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
fsynced_write_or_cleanup "$tmp_file" "$servicefile"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 416:
mkdir -p $dropdownfolder || revert_and_fail "Could not create dir: $dropdownfolder"
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mkdir -p "$dropdownfolder" || revert_and_fail "Could not create dir: $dropdownfolder"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 421:
rm -f $tmpdropdownfile
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "$tmpdropdownfile"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 425:
CapabilityBoundingSet=~" >$tmpdropdownfile || revert_and_fail $ERR_FILE_SYSTEM "Failed to create systemd conf file for $OPKGNAME"
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
CapabilityBoundingSet=~" >"$tmpdropdownfile" || revert_and_fail "$ERR_FILE_SYSTEM" "Failed to create systemd conf file for $OPKGNAME"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 427:
chmod 644 $tmpdropdownfile
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod 644 "$tmpdropdownfile"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 428:
fsynced_write_or_cleanup $tmpdropdownfile $dropdownfile
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
fsynced_write_or_cleanup "$tmpdropdownfile" "$dropdownfile"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 438:
chown $OPKGNAME:addon -R $INSTALL_DIR ||
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chown "$OPKGNAME":addon -R "$INSTALL_DIR" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 439:
revert_and_fail $ERR_FILE_SYSTEM "Failed to change owner of the addon to $OPKGNAME"
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_FILE_SYSTEM" "Failed to change owner of the addon to $OPKGNAME"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 440:
chmod -R $PERM_OTHERDIR $INSTALL_DIR ||
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod -R $PERM_OTHERDIR "$INSTALL_DIR" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 441:
revert_and_fail $ERR_FILE_SYSTEM "Failed to set file permission for addon directory and its content"
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_FILE_SYSTEM" "Failed to set file permission for addon directory and its content"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 443:
for addon_sub_dir in $(find -H $INSTALL_DIR -type f); do
^-----------------------------^ SC2044 (warning): For loops over find output are fragile. Use find -exec or a while read loop.
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
for addon_sub_dir in $(find -H "$INSTALL_DIR" -type f); do
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 444:
chmod $PERM_OTHER $addon_sub_dir
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod $PERM_OTHER "$addon_sub_dir"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 449:
chmod $PERM_EXECDIR $INSTALL_DIR ||
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod $PERM_EXECDIR "$INSTALL_DIR" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 450:
revert_and_fail $ERR_FILE_SYSTEM "Failed to set executable permission for $INSTALL_DIR"
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_FILE_SYSTEM" "Failed to set executable permission for $INSTALL_DIR"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 452:
chmod $PERM_EXECDIR $INSTALL_DIR/usr ||
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod $PERM_EXECDIR "$INSTALL_DIR"/usr ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 453:
revert_and_fail $ERR_FILE_SYSTEM "Failed to set executable permission for $INSTALL_DIR/usr"
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_FILE_SYSTEM" "Failed to set executable permission for $INSTALL_DIR/usr"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 457:
chmod -R $PERM_BINFILES $INSTALL_DIR/usr/bin/* ||
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod -R $PERM_BINFILES "$INSTALL_DIR"/usr/bin/* ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 458:
revert_and_fail $ERR_FILE_SYSTEM "Failed to set file permission for addon binaries"
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_FILE_SYSTEM" "Failed to set file permission for addon binaries"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 468:
local addon_sub_file addon_sub_file
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 470:
chown $OPKGNAME:addon $INSTALL_DIR ||
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chown "$OPKGNAME":addon "$INSTALL_DIR" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 471:
revert_and_fail $ERR_FILE_SYSTEM "Failed to change owner of the addon to $OPKGNAME"
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_FILE_SYSTEM" "Failed to change owner of the addon to $OPKGNAME"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 473:
for addon_sub_file in $(find -H $INSTALL_DIR -type f); do
^-----------------------------^ SC2044 (warning): For loops over find output are fragile. Use find -exec or a while read loop.
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
for addon_sub_file in $(find -H "$INSTALL_DIR" -type f); do
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 475:
if [ $addon_sub_dir != $INSTALL_DIR/usr/lib ];then
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$addon_sub_dir" != "$INSTALL_DIR"/usr/lib ];then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 476:
chown $OPKGNAME:addon $addon_sub_file
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chown "$OPKGNAME":addon "$addon_sub_file"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 477:
chown $OPKGNAME:addon $addon_sub_dir
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chown "$OPKGNAME":addon "$addon_sub_dir"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 478:
chmod $PERM_OTHER $addon_sub_file
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod $PERM_OTHER "$addon_sub_file"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 484:
chmod $PERM_EXECDIR $INSTALL_DIR ||
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod $PERM_EXECDIR "$INSTALL_DIR" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 485:
revert_and_fail $ERR_FILE_SYSTEM "Failed to set executable permission for $INSTALL_DIR"
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_FILE_SYSTEM" "Failed to set executable permission for $INSTALL_DIR"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 487:
chmod $PERM_EXECDIR $INSTALL_DIR/usr ||
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod $PERM_EXECDIR "$INSTALL_DIR"/usr ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 488:
revert_and_fail $ERR_FILE_SYSTEM "Failed to set executable permission for $INSTALL_DIR/usr"
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_FILE_SYSTEM" "Failed to set executable permission for $INSTALL_DIR/usr"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 492:
chmod -R $PERM_BINFILES $INSTALL_DIR/usr/bin/* ||
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod -R $PERM_BINFILES "$INSTALL_DIR"/usr/bin/* ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 493:
revert_and_fail $ERR_FILE_SYSTEM "Failed to set file permission for addon binaries"
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_FILE_SYSTEM" "Failed to set file permission for addon binaries"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 501:
mkdir -p $WEB_FOLDER || revert_and_fail "Could not create dir: $WEB_FOLDER"
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mkdir -p "$WEB_FOLDER" || revert_and_fail "Could not create dir: $WEB_FOLDER"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 505:
mkdir -p $HTTP_CONF_DIR || revert_and_fail "Could not create dir: $HTTP_CONF_DIR"
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mkdir -p "$HTTP_CONF_DIR" || revert_and_fail "Could not create dir: $HTTP_CONF_DIR"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 507:
ln -sfn $WEB_FOLDER $WEB_ROOT$OPKGNAME > /dev/null 2>&1 ||
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
ln -sfn "$WEB_FOLDER" "$WEB_ROOT""$OPKGNAME" > /dev/null 2>&1 ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 508:
revert_and_fail $ERR_FILE_SYSTEM "Failed to configure web server for $OPKGNAME"
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_FILE_SYSTEM" "Failed to configure web server for $OPKGNAME"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 512:
local lic_file urls_list
^----------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 514:
[ $# -eq 1 ] || revert_and_fail $ERR_FILE_SYSTEM 'Missing url list while configuring license'
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ $# -eq 1 ] || revert_and_fail "$ERR_FILE_SYSTEM" 'Missing url list while configuring license'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 519:
lic_file=$(get_path $OPKGNAME/LICENSE) || revert_and_fail 'No license file'
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
lic_file=$(get_path "$OPKGNAME"/LICENSE) || revert_and_fail 'No license file'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 523:
chown $OPKGNAME:www $lic_file ||
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chown "$OPKGNAME":www "$lic_file" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 524:
revert_and_fail $ERR_FILE_SYSTEM 'Failed to set ownership of the license file'
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_FILE_SYSTEM" 'Failed to set ownership of the license file'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 528:
chmod $PERM_LICFILE $lic_file ||
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod $PERM_LICFILE "$lic_file" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 529:
revert_and_fail $ERR_FILE_SYSTEM 'Failed to file permissions for the license file'
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_FILE_SYSTEM" 'Failed to file permissions for the license file'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 531:
ln -sf $lic_file $WEB_FOLDER/LICENSE > /dev/null 2>&1 ||
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
ln -sf "$lic_file" "$WEB_FOLDER"/LICENSE > /dev/null 2>&1 ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 532:
revert_and_fail $ERR_FILE_SYSTEM 'Failed to expose license'
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_FILE_SYSTEM" 'Failed to expose license'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 546:
local rewrite_file=$HTTP_CONF_DIR/$ADDON_MAIN_REWRITE_FILE
^----------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
local rewrite_file="$HTTP_CONF_DIR"/"$ADDON_MAIN_REWRITE_FILE"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 547:
local tmp_file=$rewrite_file.tmp
^------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
local tmp_file="$rewrite_file".tmp
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 549:
rm -f $tmp_file
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "$tmp_file"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 552:
RewriteRule \"^/$\" \"/local/$OPKGNAME/$1\" [L]" >$tmp_file ||
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
RewriteRule \"^/$\" \"/local/$OPKGNAME/$1\" [L]" >"$tmp_file" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 553:
revert_and_fail $ERR_FILE_SYSTEM "Could not create file: $ADDON_MAIN_REWRITE_FILE"
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_FILE_SYSTEM" "Could not create file: $ADDON_MAIN_REWRITE_FILE"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 555:
fsynced_write_or_cleanup $tmp_file $rewrite_file
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
fsynced_write_or_cleanup "$tmp_file" "$rewrite_file"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 564:
local alternative_webroot=//Supplies/WebContent/AlternativeRoot i=0
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 565:
local main_webpage=//MainPage count=0 url_to_redirect main_webpage_file
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 566:
local alt_webroot_conf_file=$HTTP_CONF_DIR/40_addon_webroot_alt_$OPKGNAME.conf
^-------------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
local alt_webroot_conf_file="$HTTP_CONF_DIR"/40_addon_webroot_alt_"$OPKGNAME".conf
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 567:
local tmp_file=$alt_webroot_conf_file.tmp
^------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
local tmp_file="$alt_webroot_conf_file".tmp
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 575:
revert_and_fail $ERR_MANIFEST 'Fail to extract alternativeWebroot from manifest'
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" 'Fail to extract alternativeWebroot from manifest'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 579:
rm -f $tmp_file
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "$tmp_file"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 581:
[ ! -f $ADDON_MAIN_REWRITE_FILE ] && [ $count -lt 1 ] || {
^----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -f "$ADDON_MAIN_REWRITE_FILE" ] && [ "$count" -lt 1 ] || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 583:
RewriteRule ^/$OPKGNAME/(.*)\$ /local/$OPKGNAME/\$1 [N] " >$tmp_file || revert_and_fail $ERR_FILE_SYSTEM "Could not create file: $tmp_file"
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
RewriteRule ^/$OPKGNAME/(.*)\$ /local/$OPKGNAME/\$1 [N] " >"$tmp_file" || revert_and_fail "$ERR_FILE_SYSTEM" "Could not create file: $tmp_file"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 586:
while [ $i -lt $count ]; do
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
while [ $i -lt "$count" ]; do
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 587:
i=$(($i + 1))
^-- SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 589:
url_to_redirect=$(get_manifest_xpath "string($alternative_webroot[$i])") ||
^-- SC1087 (error): Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 590:
revert_and_fail $ERR_MANIFEST 'Fail to extract AlternativeRoot name from manifest'
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" 'Fail to extract AlternativeRoot name from manifest'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 593:
RewriteRule ^$url_to_redirect/(.*)\$ /local/$OPKGNAME/\$1 [N]" >>$tmp_file ||
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
RewriteRule ^$url_to_redirect/(.*)\$ /local/$OPKGNAME/\$1 [N]" >>"$tmp_file" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 594:
revert_and_fail $ERR_FILE_SYSTEM "Could not append to file: $tmp_file"
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_FILE_SYSTEM" "Could not append to file: $tmp_file"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 597:
[ -f $tmp_file ] &&
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -f "$tmp_file" ] &&
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 598:
fsynced_write_or_cleanup $tmp_file $alt_webroot_conf_file
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
fsynced_write_or_cleanup "$tmp_file" "$alt_webroot_conf_file"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 601:
create_rewrites_symlinks $OPKGNAME
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
create_rewrites_symlinks "$OPKGNAME"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 605:
local fcgiUrl=//Supplies/Fcgis/Url count i=0 fcgi_file aliasurl aliasconf aliasconf_tmp fcgis_list fcgis_handlers_list
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 611:
touch $FCGI_SOCK || revert_and_fail $ERR_FILE_SYSTEM "Failed to create fastcgi socket"
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
touch "$FCGI_SOCK" || revert_and_fail "$ERR_FILE_SYSTEM" "Failed to create fastcgi socket"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 614:
revert_and_fail $ERR_MANIFEST 'Fail to extract fcgi data from manifest'
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" 'Fail to extract fcgi data from manifest'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 617:
remove_addon_url_alias $OPKGNAME || revert_and_fail $ERR_FILE_SYSTEM "Failed to delete previous alias file"
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
remove_addon_url_alias "$OPKGNAME" || revert_and_fail "$ERR_FILE_SYSTEM" "Failed to delete previous alias file"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 622:
while [ $i -lt $count ]; do
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
while [ $i -lt "$count" ]; do
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 623:
i=$(($i + 1))
^-- SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 624:
fcgi_file=$(get_manifest_xpath "string($fcgiUrl[$i])") ||
^-- SC1087 (error): Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 625:
revert_and_fail $ERR_MANIFEST 'Fail to extract fcgi file from manifest'
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" 'Fail to extract fcgi file from manifest'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 627:
group=$(get_manifest_xpath "string($fcgiUrl[$i]/@AccessGroup)") ||
^-- SC1087 (error): Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 628:
revert_and_fail $ERR_MANIFEST 'Fail to extract fcgi group from manifest'
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_MANIFEST" 'Fail to extract fcgi group from manifest'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 630:
aliasurl=$(get_manifest_xpath "string($fcgiUrl[$i]/@AlternativeUrl)") || {
^-- SC1087 (error): Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 637:
touch $WEB_FOLDER/$fcgi_file || revert_and_fail $ERR_FILE_SYSTEM "Failed to create fast CGI alias $fcgi_file"
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
touch "$WEB_FOLDER"/"$fcgi_file" || revert_and_fail "$ERR_FILE_SYSTEM" "Failed to create fast CGI alias $fcgi_file"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 639:
[ -z "$aliasurl" ] || echo "Alias $aliasurl $WEB_DOCUMENT_ROOT/local/$OPKGNAME/$fcgi_file" >> $aliasconf_tmp
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -z "$aliasurl" ] || echo "Alias $aliasurl $WEB_DOCUMENT_ROOT/local/$OPKGNAME/$fcgi_file" >> "$aliasconf_tmp"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 643:
fcgis_handlers_list=$(append_addon_fcgi_handler_configuration $fcgi_file $FCGI_SOCK "$fcgis_handlers_list") || revert_and_fail $ERR_CREATE_FCGI "Missing arguments"
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
fcgis_handlers_list=$(append_addon_fcgi_handler_configuration "$fcgi_file" "$FCGI_SOCK" "$fcgis_handlers_list") || revert_and_fail "$ERR_CREATE_FCGI" "Missing arguments"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 644:
fcgis_list=$(append_addon_fcgi_configuration $fcgi_file $group "$fcgis_list") || revert_and_fail $ERR_CREATE_FCGI "Missing arguments"
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
fcgis_list=$(append_addon_fcgi_configuration "$fcgi_file" "$group" "$fcgis_list") || revert_and_fail "$ERR_CREATE_FCGI" "Missing arguments"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 647:
create_addon_fcgis_handlers_configuration $OPKGNAME "$fcgis_handlers_list" || revert_and_fail $ERR_CREATE_FCGI 'Failed to create FCGI handlers configuration'
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
create_addon_fcgis_handlers_configuration "$OPKGNAME" "$fcgis_handlers_list" || revert_and_fail "$ERR_CREATE_FCGI" 'Failed to create FCGI handlers configuration'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 648:
create_addon_fcgis_configuration $OPKGNAME "$fcgis_list" ||
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
create_addon_fcgis_configuration "$OPKGNAME" "$fcgis_list" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 649:
revert_and_fail $ERR_CREATE_FCGI 'Failed to create FCGI configuration'
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_CREATE_FCGI" 'Failed to create FCGI configuration'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 653:
[ ! -f $aliasconf_tmp ] || {
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -f "$aliasconf_tmp" ] || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 654:
mv $aliasconf_tmp $aliasconf || revert_and_fail $ERR_CREATE_FCGI 'Failed to move configuration file'
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mv "$aliasconf_tmp" "$aliasconf" || revert_and_fail "$ERR_CREATE_FCGI" 'Failed to move configuration file'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 659:
local main_webpage=//MainPage main_webpage_file group urls_list is_webroot i=0
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 661:
[ "$1" ] || revert_and_fail $ERR_FILE_SYSTEM 'Missing url list while configuring main webpage'
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$1" ] || revert_and_fail "$ERR_FILE_SYSTEM" 'Missing url list while configuring main webpage'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 667:
if [ $count -eq 1 ]; then
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$count" -eq 1 ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 678:
create_rewrite_webroot_conf_file $main_webpage_file
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
create_rewrite_webroot_conf_file "$main_webpage_file"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 683:
urls_list=$(append_addon_url_configuration $main_webpage_file $group "$urls_list") || revert_and_fail $ERR_CREATE_URL "Failed to append url entry for main webpage '$main_webpage_file'"
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
urls_list=$(append_addon_url_configuration "$main_webpage_file" "$group" "$urls_list") || revert_and_fail "$ERR_CREATE_URL" "Failed to append url entry for main webpage '$main_webpage_file'"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 691:
local webpage=//Page count webpage_file group i=0 urls_list
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 693:
[ "$1" ] || revert_and_fail $ERR_FILE_SYSTEM "Missing url list while configuring main webpage"
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$1" ] || revert_and_fail "$ERR_FILE_SYSTEM" "Missing url list while configuring main webpage"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 699:
while [ $i -lt $count ]; do
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
while [ $i -lt "$count" ]; do
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 700:
i=$(($i + 1))
^-- SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 701:
webpage_file=$(get_manifest_xpath "string($webpage[$i])") ||
^-- SC1087 (error): Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 708:
group=$(get_manifest_xpath "string($webpage[$i]/@AccessGroup)") ||
^-- SC1087 (error): Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 711:
urls_list=$(append_addon_url_configuration $webpage_file $group "$urls_list") ||
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
urls_list=$(append_addon_url_configuration "$webpage_file" "$group" "$urls_list") ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 712:
revert_and_fail $ERR_CREATE_URL "Failed to add url entry for file '$webpage_file'"
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_CREATE_URL" "Failed to add url entry for file '$webpage_file'"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 720:
local urls_list
^-------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 726:
create_addon_urls_configuration $OPKGNAME "$urls_list" ||
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
create_addon_urls_configuration "$OPKGNAME" "$urls_list" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 727:
revert_and_fail $ERR_CREATE_URL 'Failed to create URLS configuration'
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_CREATE_URL" 'Failed to create URLS configuration'
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 731:
remove_addon_configuration $OPKGNAME || :
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
remove_addon_configuration "$OPKGNAME" || :
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 735:
local web_sub_dir
^---------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 741:
chown -R $OPKGNAME:www $WEB_FOLDER ||
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chown -R "$OPKGNAME":www "$WEB_FOLDER" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 742:
revert_and_fail $ERR_FILE_SYSTEM "Failed to change owner for $WEB_FOLDER and its content"
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_FILE_SYSTEM" "Failed to change owner for $WEB_FOLDER and its content"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 744:
chmod -R $PERM_WEBFILES $WEB_FOLDER ||
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod -R $PERM_WEBFILES "$WEB_FOLDER" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 745:
revert_and_fail $ERR_FILE_SYSTEM "Failed to set permission for $WEB_FOLDER and its content"
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_FILE_SYSTEM" "Failed to set permission for $WEB_FOLDER and its content"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 747:
chmod $PERM_WEBDIR $WEB_FOLDER ||
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod $PERM_WEBDIR "$WEB_FOLDER" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 748:
revert_and_fail $ERR_FILE_SYSTEM "Failed to set permission for $WEB_FOLDER and its content"
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_FILE_SYSTEM" "Failed to set permission for $WEB_FOLDER and its content"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 750:
for web_sub_dir in $(find -H $WEB_FOLDER -type d); do
^----------------------------^ SC2044 (warning): For loops over find output are fragile. Use find -exec or a while read loop.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
for web_sub_dir in $(find -H "$WEB_FOLDER" -type d); do
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 751:
chmod $PERM_WEBDIR $web_sub_dir || revert_and_fail $ERR_FILE_SYSTEM "Failed to set permissions for $WEB_FOLDER sub directories"
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod $PERM_WEBDIR "$web_sub_dir" || revert_and_fail "$ERR_FILE_SYSTEM" "Failed to set permissions for $WEB_FOLDER sub directories"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 760:
local layer_tars upperdir workdir mergeddir lowerdir layer layer_dir
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 761:
local lower_layer= layers_dir=/opt/layers tmp_dir layer_tar
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
^-- SC1007 (warning): Remove space after = if trying to assign a value (for empty string, use var='' ... ).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 762:
local lower_tmp diff_tmp
^----------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 767:
tar -C $tmp_dir -xf /opt/$OPKGNAME/usr/misc/layer/oci_layers.tar ||
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tar -C "$tmp_dir" -xf /opt/"$OPKGNAME"/usr/misc/layer/oci_layers.tar ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 770:
layer_tars=$(sed -e 's/.*"Layers":\[\([^]]*\)\].*/\1/' -e 's/,/ /g' -e 's/"//g' $tmp_dir/manifest.json)
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
layer_tars=$(sed -e 's/.*"Layers":\[\([^]]*\)\].*/\1/' -e 's/,/ /g' -e 's/"//g' "$tmp_dir"/manifest.json)
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 776:
if [ ! -d $layer_dir ]; then
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ ! -d "$layer_dir" ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 777:
mkdir -p $layer_dir/ref ||
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mkdir -p "$layer_dir"/ref ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 780:
mkdir -p $layer_dir/work ||
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mkdir -p "$layer_dir"/work ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 783:
[ -z $lower_layer ] || {
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -z "$lower_layer" ] || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 785:
rm -f $lower_tmp
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "$lower_tmp"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 786:
[ ! -f $layer_dir/lower ] || cat $layer_dir/lower >$lower_tmp ||
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -f "$layer_dir"/lower ] || cat "$layer_dir"/lower >"$lower_tmp" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 789:
echo "$layers_dir/$lower_layer" >>$lower_tmp ||
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$layers_dir/$lower_layer" >>"$lower_tmp" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 792:
fsynced_write_or_cleanup $lower_tmp $layer_dir/lower
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
fsynced_write_or_cleanup "$lower_tmp" "$layer_dir"/lower
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 796:
[ ! -d $layer_dir/diff ] || rm -rf $layer_dir/diff 2>&
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -d "$layer_dir"/diff ] || rm -rf "$layer_dir"/diff 2>&1
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 797:
rm -rf $diff_tmp 2>&
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -rf "$diff_tmp" 2>&1
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 799:
mkdir -p $diff_tmp ||
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mkdir -p "$diff_tmp" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 802:
tar -C $diff_tmp -xf $tmp_dir/$layer_tar
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tar -C "$diff_tmp" -xf "$tmp_dir"/"$layer_tar"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 806:
mv $diff_tmp $layer_dir/diff || {
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mv "$diff_tmp" "$layer_dir"/diff || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 807:
rm -rf $diff_tmp 2>&
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -rf "$diff_tmp" 2>&1
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 811:
fsync $layer_dir || {
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
fsync "$layer_dir" || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 812:
rm -rf $diff_tmp 2>&
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -rf "$diff_tmp" 2>&1
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 816:
[ -z $lower_layer ] || >$layers_dir/$lower_layer/ref/$layer
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2188 (warning): This redirection doesn't have a command. Move to its command (or use 'true' as no-op).
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -z "$lower_layer" ] || >$layers_dir/"$lower_layer"/ref/"$layer"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 820:
rm -rf $tmp_dir
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -rf "$tmp_dir"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 826:
while [ -f $layer_dir/lower ]; do
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
while [ -f "$layer_dir"/lower ]; do
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 827:
[ -r $layer_dir/lower ] ||
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -r "$layer_dir"/lower ] ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 828:
revert_and_fail $ERR_INSTALL_ERROR "Cannot mount addon layers"
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
revert_and_fail "$ERR_INSTALL_ERROR" "Cannot mount addon layers"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 829:
read layer_dir <$layer_dir/lower
^--^ SC2162 (info): read without -r will mangle backslashes.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
read layer_dir <"$layer_dir"/lower
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 836:
rm -rf $mergeddir/*
^----------^ SC2115 (warning): Use "${var:?}" to ensure this never expands to /* .
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -rf "$mergeddir"/*
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 837:
local mount_options="lowerdir=$lowerdir,upperdir=$upperdir,workdir=$workdir $mergeddir"
^-----------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 838:
mount -t overlay overlay -o $mount_options ||
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mount -t overlay overlay -o "$mount_options" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 841:
sed -i '$ a overlay '$mergeddir' overlay '"$mount_options"' 0 0' /etc/fstab
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
sed -i '$ a overlay '"$mergeddir"' overlay '"$mount_options"' 0 0' /etc/fstab
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 852:
get_uid_for_user $OPKGNAME result || revert_and_fail $ERR_INSTALL_ERROR "Failed to check if Add-on user $OPKGNAME exists"
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
get_uid_for_user "$OPKGNAME" result || revert_and_fail "$ERR_INSTALL_ERROR" "Failed to check if Add-on user $OPKGNAME exists"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 855:
if [ $result -eq -1 ]; then
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$result" -eq -1 ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 858:
create_addon_user $OPKGNAME "$sec_groups" || revert_and_fail $ERR_INSTALL_ADDON_USER "Failed to create user $OPKGNAME"
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
create_addon_user "$OPKGNAME" "$sec_groups" || revert_and_fail "$ERR_INSTALL_ADDON_USER" "Failed to create user $OPKGNAME"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 859:
elif [ $result -ge 500 ]; then
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
elif [ "$result" -ge 500 ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 863:
update_addon_user_groups $OPKGNAME "$sec_groups" || revert_and_fail $ERR_INSTALL_ADDON_USER "Failed to update user $OPKGNAME"
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
update_addon_user_groups "$OPKGNAME" "$sec_groups" || revert_and_fail "$ERR_INSTALL_ADDON_USER" "Failed to update user $OPKGNAME"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-80367616.squashfs_v4_le_extract/usr/bin/addon-setup line 867:
if [ -d /opt/$OPKGNAME/usr/misc/layer/ ]; then
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -d /opt/"$OPKGNAME"/usr/misc/layer/ ]; then
For more information:
https://www.shellcheck.net/wiki/SC1087 -- Use braces when expanding arrays,...
https://www.shellcheck.net/wiki/SC1007 -- Remove space after = if trying to...
https://www.shellcheck.net/wiki/SC2034 -- FIRST_BOOT_MODE appears unused. V...
