In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/temperature_status.sh line 6:
logger -s -t$SELF -p err -- $*
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2048 (warning): Use "$@" (with quotes) to prevent whitespace problems.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
logger -s -t"$SELF" -p err -- "$*"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/temperature_status.sh line 16:
' $SELF
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
' "$SELF"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/temperature_status.sh line 20:
local name=
^--------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/temperature_status.sh line 27:
if name=$($GDBUS_GET_TEMP_NAME $1 2>/dev/null) && [ "$name" ]; then
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if name=$($GDBUS_GET_TEMP_NAME "$1" 2>/dev/null) && [ "$name" ]; then
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/temperature_status.sh line 38:
local temp=-999
^--------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/temperature_status.sh line 47:
local dec=0
^-------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/temperature_status.sh line 57:
local rest=${dec#??}
^--------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
local rest="${dec#??}"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/temperature_status.sh line 58:
dec=${dec%$rest}
^---^ SC2295 (info): Expansions inside ${..} need to be quoted separately, otherwise they match as patterns.
Did you mean:
dec=${dec%"$rest"}
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/temperature_status.sh line 65:
echo Sensor S$1: $temp.${dec%$rest} C $name
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---^ SC2295 (info): Expansions inside ${..} need to be quoted separately, otherwise they match as patterns.
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo Sensor S"$1": "$temp"."${dec%"$rest"}" C "$name"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/temperature_status.sh line 85:
shift $(($OPTIND - 1))
^-----^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/temperature_status.sh line 105:
set -- $sensor
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
set -- "$sensor"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/temperature_status.sh line 107:
[ $# -lt 3 ] || print_temp $1 $2 $3
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ $# -lt 3 ] || print_temp "$1" "$2" "$3"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/temperature_status.sh line 112:
all_count_cmd=`sed 's/\\t/\\n/g' < $logf | sed 's/\\[/\\n/g' | grep 'Hi/\|Lo/' | cut -d/ -f2 | add_numbers.sh`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
all_count_cmd=$(sed 's/\\t/\\n/g' < $logf | sed 's/\\[/\\n/g' | grep 'Hi/\|Lo/' | cut -d/ -f2 | add_numbers.sh)
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/temperature_status.sh line 113:
hi_count_cmd=`sed 's/\\t/\\n/g' < $logf | sed 's/\\[/\\n/g' | grep 'Hi/' | cut -d/ -f2 | add_numbers.sh`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
hi_count_cmd=$(sed 's/\\t/\\n/g' < $logf | sed 's/\\[/\\n/g' | grep 'Hi/' | cut -d/ -f2 | add_numbers.sh)
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/temperature_status.sh line 114:
lo_count_cmd=`sed 's/\\t/\\n/g' < $logf | sed 's/\\[/\\n/g' | grep 'Lo/' | cut -d/ -f2 | add_numbers.sh`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
lo_count_cmd=$(sed 's/\\t/\\n/g' < $logf | sed 's/\\[/\\n/g' | grep 'Lo/' | cut -d/ -f2 | add_numbers.sh)
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/temperature_status.sh line 116:
[ ! -r $logf ] || echo "TempCounter:" $all_count_cmd
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -r $logf ] || echo "TempCounter:" "$all_count_cmd"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/temperature_status.sh line 117:
[ ! -r $logf ] || echo "HighTemp:" $hi_count_cmd
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -r $logf ] || echo "HighTemp:" "$hi_count_cmd"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/temperature_status.sh line 118:
[ ! -r $logf ] || echo "LowTemp:" $lo_count_cmd
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -r $logf ] || echo "LowTemp:" "$lo_count_cmd"
For more information:
https://www.shellcheck.net/wiki/SC2048 -- Use "$@" (with quotes) to prevent...
https://www.shellcheck.net/wiki/SC3043 -- In POSIX sh, 'local' is undefined.
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
