In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 4:
TAG="$SELF[$$]"
^-- SC1087 (error): Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 9:
logger -t $TAG -p warning "$*"
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
logger -t "$TAG" -p warning "$*"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 18:
local tempfile old_data d
^-----------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 21:
[ ! -f $2 ] || old_data=$(cat $2) || return 1
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -f "$2" ] || old_data=$(cat "$2") || return 1
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 23:
[ ! -f $2 ] || cp -p $2 $tempfile || return 1
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -f "$2" ] || cp -p "$2" "$tempfile" || return 1
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 24:
echo "$1" >$tempfile || return 1
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$1" >"$tempfile" || return 1
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 25:
fsync $tempfile
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
fsync "$tempfile"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 26:
mv $tempfile $2 || return 1
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mv "$tempfile" "$2" || return 1
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 28:
[ $d != $2 ] || d=.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$d" != "$2" ] || d=.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 29:
fsync $d
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
fsync "$d"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 34:
local new_data
^------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 35:
new_data=$(sed -r "$1" $2)
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
new_data=$(sed -r "$1" "$2")
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 36:
safe_print "$new_data" $2
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
safe_print "$new_data" "$2"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 40:
[ $# -eq 3 ] && [ "$1" ] && [ "$2" ] && [ "$3" ] ||
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 43:
local resolution_small=$3
^--------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
local resolution_small="$3"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 44:
grep -q "^[[:blank:]]*Resolution[[:blank:]]*=[[:blank:]]*[\"]*$resolution_small[\"]*$" $1 ||
^-- SC1087 (error): Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
grep -q "^[[:blank:]]*Resolution[[:blank:]]*=[[:blank:]]*[\"]*$resolution_small[\"]*$" "$1" ||
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 45:
safe_sed "s/^([[:blank:]]*Resolution[[:blank:]]*=[[:blank:]]*\"?)([^\"]+)(\"?)$/\1${resolution_small}\3/" $1 ||
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
safe_sed "s/^([[:blank:]]*Resolution[[:blank:]]*=[[:blank:]]*\"?)([^\"]+)(\"?)$/\1${resolution_small}\3/" "$1" ||
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 47:
chown $2 $1 || croak "could not set owner to $2 for file $1"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chown "$2" "$1" || croak "could not set owner to $2 for file $1"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 55:
[ "$1" ] && [ "$2" ] || croak "$err_msg : $*"
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update_motion line 64:
write_small_resolution $1 $2 $RESOLUTION_SMALL
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
write_small_resolution "$1" "$2" "$RESOLUTION_SMALL"
For more information:
https://www.shellcheck.net/wiki/SC1087 -- Use braces when expanding arrays,...
https://www.shellcheck.net/wiki/SC3043 -- In POSIX sh, 'local' is undefined.
https://www.shellcheck.net/wiki/SC2015 -- Note that A && B || C is not if-t...