In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 3:
. /lib/rcscripts/sh/string.sh
^-------------------------^ SC1091 (info): Not following: /lib/rcscripts/sh/string.sh was not specified as input (see shellcheck -x).
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 6:
TAG="$SELF[$$]"
^-- SC1087 (error): Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 10:
LOCKFPATH="$_LFD/$LOCKF"
^-------^ SC2034 (warning): LOCKFPATH appears unused. Verify use (or export if used externally).
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 13:
[ -z "$TMP_FILE" ] || rm -f $TMP_FILE
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -z "$TMP_FILE" ] || rm -f "$TMP_FILE"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 17:
local _f=lock_file_validate
^------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 20:
local __lf
^--------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 28:
eval $2="$_LFD/$__lf.lock" ||
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$2"="$_LFD/$__lf.lock" ||
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 34:
local _f=lock_file_remove _lf
^---------------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 38:
lock_file_validate $1 _lf
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
lock_file_validate "$1" _lf
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 40:
[ ! -e $_lf ] || {
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -e "$_lf" ] || {
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 41:
read _pid < $_lf ||
^--^ SC2162 (info): read without -r will mangle backslashes.
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
read _pid < "$_lf" ||
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 43:
[ "$_pid" != $$ ] || rm -f $_lf
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$_pid" != $$ ] || rm -f "$_lf"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 52:
local _f=lock_file_create _lf
^---------------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 56:
lock_file_validate $1 _lf
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
lock_file_validate "$1" _lf
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 61:
pid2=$$
^--^ SC2034 (warning): pid2 appears unused. Verify use (or export if used externally).
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 62:
exec 200>"$_lf"
^--------^ SC3023 (warning): In POSIX sh, FDs outside 0-9 are undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 74:
logger -t $TAG -p warning "$*"
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
logger -t "$TAG" -p warning "$*"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 85:
FOCUSWINDOW_DEFAULT=0.15,0.15:0.85,0.15:0.85,0.85:0.15,0.85
^-----------------^ SC2034 (warning): FOCUSWINDOW_DEFAULT appears unused. Verify use (or export if used externally).
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 93:
sysconfdir=/etc/sysconfig
^--------^ SC2034 (warning): sysconfdir appears unused. Verify use (or export if used externally).
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 98:
local tempfile old_data d
^-----------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 101:
[ ! -f $2 ] || old_data=$(cat $2) || return 1
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -f "$2" ] || old_data=$(cat "$2") || return 1
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 103:
[ ! -f $2 ] || cp -p $2 $tempfile || return 1
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -f "$2" ] || cp -p "$2" "$tempfile" || return 1
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 104:
echo "$1" >$tempfile || return 1
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$1" >"$tempfile" || return 1
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 105:
fsync $tempfile
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
fsync "$tempfile"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 106:
mv $tempfile $2 || return 1
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mv "$tempfile" "$2" || return 1
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 108:
[ $d != $2 ] || d=.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$d" != "$2" ] || d=.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 109:
fsync $d
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
fsync "$d"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 114:
local new_data
^------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 115:
new_data=$(sed -r "$1" $2)
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
new_data=$(sed -r "$1" "$2")
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 116:
safe_print "$new_data" $2
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
safe_print "$new_data" "$2"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 126:
[ $# -ge 1 ] && [ "$1" ] ||
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 129:
local drop_file drop_files=/usr/share/resolution_update/resolution_update_dir.d/*
^------------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^-- SC2125 (warning): Brace expansions and globs are literal in assignments. Quote it or use an array.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 131:
[ ! -f $drop_file ] || [ ! -x $drop_file ] || {
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -f "$drop_file" ] || [ ! -x "$drop_file" ] || {
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 132:
local RESOLUTION_UPDATE_ACTION=$1
^----------------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^----------------------^ SC2034 (warning): RESOLUTION_UPDATE_ACTION appears unused. Verify use (or export if used externally).
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
local RESOLUTION_UPDATE_ACTION="$1"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 133:
local RESOLUTION_UPDATE_PAR1=$2
^--------------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^--------------------^ SC2034 (warning): RESOLUTION_UPDATE_PAR1 appears unused. Verify use (or export if used externally).
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
local RESOLUTION_UPDATE_PAR1="$2"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 134:
local RESOLUTION_UPDATE_PAR2=$3
^--------------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^--------------------^ SC2034 (warning): RESOLUTION_UPDATE_PAR2 appears unused. Verify use (or export if used externally).
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
local RESOLUTION_UPDATE_PAR2="$3"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 135:
. $drop_file || croak "Could not source $drop_file"
^--------^ SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
. "$drop_file" || croak "Could not source $drop_file"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 143:
[ $# -eq 3 ] && [ "$1" ] && [ "$2" ] && [ "$3" ] ||
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 146:
local drop_file drop_files=$1/*
^------------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^--^ SC2125 (warning): Brace expansions and globs are literal in assignments. Quote it or use an array.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
local drop_file drop_files="$1"/*
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 148:
[ ! -f $drop_file ] || [ ! -x $drop_file ] || {
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -f "$drop_file" ] || [ ! -x "$drop_file" ] || {
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 149:
local RESOLUTION_UPDATE_COMMAND=$2
^-----------------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^-----------------------^ SC2034 (warning): RESOLUTION_UPDATE_COMMAND appears unused. Verify use (or export if used externally).
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
local RESOLUTION_UPDATE_COMMAND="$2"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 150:
local RESOLUTION_UPDATE_STREAM_IDS=$3
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
^--------------------------^ SC2034 (warning): RESOLUTION_UPDATE_STREAM_IDS appears unused. Verify use (or export if used externally).
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
local RESOLUTION_UPDATE_STREAM_IDS="$3"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 151:
. $drop_file || croak "Could not source $drop_file"
^--------^ SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
. "$drop_file" || croak "Could not source $drop_file"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 157:
local cmprefix=/etc/image2d/cml do_reset=false cmfile streamid
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 158:
local streamids=
^-------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 160:
for cmfile in $cmprefix*; do
^-------^ SC2231 (info): Quote expansions in this for loop glob to prevent wordsplitting, e.g. "$dir"/*.txt .
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 161:
[ ! -f $cmfile ] || {
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -f "$cmfile" ] || {
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 162:
streamid=${cmfile##$cmprefix}
^-------^ SC2295 (info): Expansions inside ${..} need to be quoted separately, otherwise they match as patterns.
Did you mean:
streamid=${cmfile##"$cmprefix"}
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 166:
rm -f $cmfile
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "$cmfile"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 172:
run_parts_deprecated /usr/share/resolution_update/resolution_update.d $START_COMMAND "$streamids"
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
run_parts_deprecated /usr/share/resolution_update/resolution_update.d "$START_COMMAND" "$streamids"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 179:
RESOLUTION_DEFAULT=$(res_finder $RES_FINDER_EXTRA_ARGS --default_res --channel $channel) ||
^----------------^ SC2034 (warning): RESOLUTION_DEFAULT appears unused. Verify use (or export if used externally).
^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
RESOLUTION_DEFAULT=$(res_finder "$RES_FINDER_EXTRA_ARGS" --default_res --channel $channel) ||
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 181:
RESOLUTION_MIN=$(res_finder $RES_FINDER_EXTRA_ARGS --min_resolution_standard) ||
^------------^ SC2034 (warning): RESOLUTION_MIN appears unused. Verify use (or export if used externally).
^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
RESOLUTION_MIN=$(res_finder "$RES_FINDER_EXTRA_ARGS" --min_resolution_standard) ||
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 183:
RESOLUTION_MAX=$(res_finder $RES_FINDER_EXTRA_ARGS --max_resolution_standard) ||
^------------^ SC2034 (warning): RESOLUTION_MAX appears unused. Verify use (or export if used externally).
^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
RESOLUTION_MAX=$(res_finder "$RES_FINDER_EXTRA_ARGS" --max_resolution_standard) ||
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 185:
RESOLUTION_MAXZOOM_NONHIDDEN=$(res_finder $RES_FINDER_EXTRA_ARGS --max_parhand_resolution) ||
^--------------------------^ SC2034 (warning): RESOLUTION_MAXZOOM_NONHIDDEN appears unused. Verify use (or export if used externally).
^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
RESOLUTION_MAXZOOM_NONHIDDEN=$(res_finder "$RES_FINDER_EXTRA_ARGS" --max_parhand_resolution) ||
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 187:
RESOLUTION_MAXZOOM=$(res_finder $RES_FINDER_EXTRA_ARGS --max_zoom_max_resolution) ||
^----------------^ SC2034 (warning): RESOLUTION_MAXZOOM appears unused. Verify use (or export if used externally).
^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
RESOLUTION_MAXZOOM=$(res_finder "$RES_FINDER_EXTRA_ARGS" --max_zoom_max_resolution) ||
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 193:
[ $# -eq 2 ] && [ "$1" ] && [ "$2" ] ||
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 205:
check_control_params $* || croak "check_control_params: invalid action '$2'"
^-- SC2048 (warning): Use "$@" (with quotes) to prevent whitespace problems.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
check_control_params "$*" || croak "check_control_params: invalid action '$2'"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 207:
[ -x $1 ] || croak "daemon_control: $1 not executable"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -x "$1" ] || croak "daemon_control: $1 not executable"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 208:
$1 $2 || croak "$1 failed to $2"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
$1 "$2" || croak "$1 failed to $2"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 212:
local opts=
^--------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 214:
check_control_params $* || {
^-- SC2048 (warning): Use "$@" (with quotes) to prevent whitespace problems.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
check_control_params "$*" || {
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 224:
systemctl $2 $1 $opts || croak "$1 failed to $2"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
systemctl "$2" "$1" $opts || croak "$1 failed to $2"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 228:
[ $# -eq 1 ] && [ "$1" ] ||
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 235:
[ $# -eq 1 ] && [ "$1" ] ||
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 243:
[ $# -eq 3 ] && [ "$1" ] && [ "$2" ] && [ "$3" ] ||
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 245:
[ -f $3 ] || return 0
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -f "$3" ] || return 0
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 247:
sed -n -e "/^\[$1\]/,/^$/s/^$2[[:blank:]]=[[:blank:]]*//p" $3
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
sed -n -e "/^\[$1\]/,/^$/s/^$2[[:blank:]]=[[:blank:]]*//p" "$3"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 251:
[ $# -eq 2 ] && [ "$1" ] && [ "$2" ] || croak "Invalid arguments $*"
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 252:
[ -f $2 ] || return 0
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -f "$2" ] || return 0
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 254:
sed -i -e "/^\[$1.*\]/,/^$/d " $2
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
sed -i -e "/^\[$1.*\]/,/^$/d " "$2"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 258:
[ $# -eq 1 ] && [ "$1" ] ||
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 261:
$PHC readgroupfile $1 ||
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
$PHC readgroupfile "$1" ||
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 267:
local ressets capmodetype i firstcapmode
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 272:
capmodetype=$(res_finder $RES_FINDER_EXTRA_ARGS -m $ressets --write_capturemode_type) ||
^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
capmodetype=$(res_finder "$RES_FINDER_EXTRA_ARGS" -m "$ressets" --write_capturemode_type) ||
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 292:
i=$(($i + 1))
^-- SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 307:
[ "$1" ] && [ "$2" ] || croak "$err_msg : $*"
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 321:
channel=$(($imagesource + 1))
^----------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 325:
res_finder $RES_FINDER_EXTRA_ARGS --update_cache
^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
res_finder "$RES_FINDER_EXTRA_ARGS" --update_cache
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 332:
TMP_FILE=$(mktemp /tmp/$SELF.XXXXXX) || croak "Can't create temporary file"
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
TMP_FILE=$(mktemp /tmp/"$SELF".XXXXXX) || croak "Can't create temporary file"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 344:
res_finder $RES_FINDER_EXTRA_ARGS --update_cache || bark '"res_finder --update-cache" failed'
^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
res_finder "$RES_FINDER_EXTRA_ARGS" --update_cache || bark '"res_finder --update-cache" failed'
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 351:
run_parts_deprecated /usr/share/resolution_update/resolution_init.d $START_COMMAND "dummy"
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
run_parts_deprecated /usr/share/resolution_update/resolution_init.d "$START_COMMAND" "dummy"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 354:
. /lib/rcscripts/sh/files.sh
^------------------------^ SC1091 (info): Not following: /lib/rcscripts/sh/files.sh was not specified as input (see shellcheck -x).
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/sbin/resolution_update line 355:
>$booted_file.tmp
^---------------^ SC2188 (warning): This redirection doesn't have a command. Move to its command (or use 'true' as no-op).
For more information:
https://www.shellcheck.net/wiki/SC1087 -- Use braces when expanding arrays,...
https://www.shellcheck.net/wiki/SC1090 -- ShellCheck can't follow non-const...
https://www.shellcheck.net/wiki/SC2034 -- FOCUSWINDOW_DEFAULT appears unuse...
