EMBA firmware report

In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/lldpd-conf-power-init line 3:

. /lib/rcscripts/sh/rc-std2parse.sh

  ^-- SC1091 (info): Not following: /lib/rcscripts/sh/rc-std2parse.sh was not specified as input (see shellcheck -x).

In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/lldpd-conf-power-init line 10:

	local max_power poe_class poe_class_low_power poe_class_high_power

        ^-- SC3043 (warning): In POSIX sh, 'local' is undefined.

In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/lldpd-conf-power-init line 11:

	[ $# -eq 2 ] && [ "$1" ] && [ "$2" ] ||

                                 ^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.

In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/lldpd-conf-power-init line 27:

			poe_class_low_power=6490

                        ^-----------------^ SC2034 (warning): poe_class_low_power appears unused. Verify use (or export if used externally).

In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/lldpd-conf-power-init line 39:

	if [ $max_power -gt $poe_class_high_power ]; then

             ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

	if [ "$max_power" -gt $poe_class_high_power ]; then

In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/lldpd-conf-power-init line 48:

	. $LLDP_CONF_RT || error "Failed to source $LLDP_CONF_RT!"

          ^-----------^ SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location.

In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/lldpd-conf-power-init line 54:

	validate_poe_conf $MAX_POWER $POE_CLASS

                          ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

                                     ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

	validate_poe_conf "$MAX_POWER" "$POE_CLASS"

In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/lldpd-conf-power-init line 56:

	[ -r $LLDP_PAR_CONF ] && [ -w $LLDP_PAR_CONF ] ||

                              ^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.

In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/lldpd-conf-power-init line 64:

	if [ $STD2_LLDPMAXPOE_MAXPOWER -ne $MAX_POWER ]; then

             ^-----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

                                           ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

	if [ "$STD2_LLDPMAXPOE_MAXPOWER" -ne "$MAX_POWER" ]; then

In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/lldpd-conf-power-init line 65:

		sed -i -re 's/^(MaxPower\s+=\s+)[0-9]+$/\1'$MAX_POWER'/' $LLDP_PAR_CONF ||

                                                           ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

		sed -i -re 's/^(MaxPower\s+=\s+)[0-9]+$/\1'"$MAX_POWER"'/' $LLDP_PAR_CONF ||

In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/lldpd-conf-power-init line 70:

	if [ $STD2_LLDPMAXPOE_POECLASS -ne $POE_CLASS ]; then

             ^-----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

                                           ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

	if [ "$STD2_LLDPMAXPOE_POECLASS" -ne "$POE_CLASS" ]; then

In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/lldpd-conf-power-init line 71:

		sed -i -re 's/^(PoeClass\s+=\s+)[0-9]+$/\1'$POE_CLASS'/' $LLDP_PAR_CONF ||

                                                           ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

		sed -i -re 's/^(PoeClass\s+=\s+)[0-9]+$/\1'"$POE_CLASS"'/' $LLDP_PAR_CONF ||

In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/lldpd-conf-power-init line 79:

	local max_power_lldpd poe_class

        ^-----------------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.

              ^-------------^ SC2034 (warning): max_power_lldpd appears unused. Verify use (or export if used externally).

In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/lldpd-conf-power-init line 91:

			class-$STD2_LLDPMAXPOE_POECLASS

                              ^-----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

			class-"$STD2_LLDPMAXPOE_POECLASS"

In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/lldpd-conf-power-init line 99:

	validate_poe_conf $STD2_LLDPMAXPOE_MAXPOWER $STD2_LLDPMAXPOE_POECLASS

                          ^-----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

                                                    ^-----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

	validate_poe_conf "$STD2_LLDPMAXPOE_MAXPOWER" "$STD2_LLDPMAXPOE_POECLASS"

In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/lldpd-conf-power-init line 102:

		spare class class-$STD2_LLDPMAXPOE_POECLASS type 1 source pse priority high \

                                  ^-----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

		spare class class-"$STD2_LLDPMAXPOE_POECLASS" type 1 source pse priority high \

In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/lldpd-conf-power-init line 103:

		requested $STD2_LLDPMAXPOE_MAXPOWER allocated $STD2_LLDPMAXPOE_MAXPOWER

                          ^-----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

                                                              ^-----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:

		requested "$STD2_LLDPMAXPOE_MAXPOWER" allocated "$STD2_LLDPMAXPOE_MAXPOWER"

For more information:

  https://www.shellcheck.net/wiki/SC1090 -- ShellCheck can't follow non-const...

  https://www.shellcheck.net/wiki/SC2034 -- max_power_lldpd appears unused. V...

  https://www.shellcheck.net/wiki/SC3043 -- In POSIX sh, 'local' is undefined.