In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 25:
[ $# -gt 0 ] && [ "$1" ] && { case $1 in (''|[!01]) ! :; esac; } ||
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 32:
exit $1
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
exit "$1"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 46:
[ $# -eq 2 ] && [ "$1" ] && [ "$2" ] ||
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 50:
mount -t $2 nodev $1 || panic "Unable to mount $1"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mount -t "$2" nodev "$1" || panic "Unable to mount $1"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 63:
MOUNTS=$(cat $pm) && [ "$MOUNTS" ] || panic "Unable to get mounts"
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 89:
[ $(ls /sys/class/mmc_host/ 2>/dev/null | wc -l) -lt 2 ] || {
^-- SC2046 (warning): Quote this to prevent word splitting.
^-- SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 104:
read type <$partsysfs/../device/type || continue
^--^ SC2162 (info): read without -r will mangle backslashes.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
read type <"$partsysfs"/../device/type || continue
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 110:
echo $trigger >/sys/class/leds/status:red/trigger 2>/dev/null ||
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$trigger" >/sys/class/leds/status:red/trigger 2>/dev/null ||
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 124:
greet "Will wait $(($timeout - $count)) more second(s) for storage"
^------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
^----^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 125:
count=$(($count + 1))
^----^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 132:
local kw=passphrase=
^------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 135:
printf "$(sed -ne "/^$kw/{s///;s/%/%%/g;p;q}" /etc/storage/storages.conf)" >/tmp/key
^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 153:
[ $(echo $dumpsd/dump-* | wc -w) -lt $max_num_dumps ] || {
^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 158:
rm -f $olddumps || whine "Unable to delete dumps"
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "$olddumps" || whine "Unable to delete dumps"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 162:
[ $(echo $dumpsd/dump-* | wc -w) -lt $max_num_dumps ] ||
^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 176:
eval $cmd || panic "Unable to save dump"
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$cmd" || panic "Unable to save dump"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 178:
etb=/dev/*.etb
^--------^ SC2125 (warning): Brace expansions and globs are literal in assignments. Quote it or use an array.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 179:
[ ! -r $etb ] || {
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -r "$etb" ] || {
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/init.crash line 181:
cp $etb $dumpsd/etb-$now || whine "Unable to save ETB"
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cp "$etb" $dumpsd/etb-"$now" || whine "Unable to save ETB"
For more information:
https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
https://www.shellcheck.net/wiki/SC2125 -- Brace expansions and globs are li...
https://www.shellcheck.net/wiki/SC3043 -- In POSIX sh, 'local' is undefined.
