In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 5:
. $rclib/rc-std2parse.sh
^--------------------^ SC1091 (info): Not following: ./rc-std2parse.sh was not specified as input (see shellcheck -x).
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 6:
. $rclib/files.sh
^-------------^ SC1091 (info): Not following: ./files.sh was not specified as input (see shellcheck -x).
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 24:
local np
^------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 30:
[ $np -lt $5 ] || np=$(($5 - 1))
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ $np -lt "$5" ] || np=$(($5 - 1))
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 31:
eval $1=$np
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$1"=$np
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 42:
local npf oldp
^------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 47:
adjust_focus npf $oldp $4 $6 $5
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
adjust_focus npf "$oldp" "$4" "$6" "$5"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 49:
eval $1=$npf
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$1"="$npf"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 60:
local cfg c cfg_mc='' cfg_l='' cfg_nl='' cfg_m='' IFS
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 71:
" $1) ||
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
" "$1") ||
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 79:
cfg_mc=${c#*=}
^----^ SC2034 (warning): cfg_mc appears unused. Verify use (or export if used externally).
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 82:
cfg_l=${c#*=}
^---^ SC2034 (warning): cfg_l appears unused. Verify use (or export if used externally).
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 85:
cfg_nl=${c#*=}
^----^ SC2034 (warning): cfg_nl appears unused. Verify use (or export if used externally).
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 88:
cfg_m=${c#*=}
^---^ SC2034 (warning): cfg_m appears unused. Verify use (or export if used externally).
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 93:
eval $3=\$cfg_mc
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$3"=\$cfg_mc
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 94:
eval $4=\$cfg_l
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$4"=\$cfg_l
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 95:
eval $5=\$cfg_nl
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$5"=\$cfg_nl
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 96:
eval $6=\$cfg_m
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$6"=\$cfg_m
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 102:
local l os= ns= bf
^----------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^-- SC1007 (warning): Remove space after = if trying to assign a value (for empty string, use var='' ... ).
^-- SC1007 (warning): Remove space after = if trying to assign a value (for empty string, use var='' ... ).
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 103:
[ $# -eq 1 ] && [ "$1" ] || error "$0: move_old_backup, bad inputs '$*'"
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 104:
[ -e $1 ] || return 0
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -e "$1" ] || return 0
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 106:
while read l; do
^--^ SC2162 (info): read without -r will mangle backslashes.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 115:
done <$1
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
done <"$1"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 116:
[ -e $bf ] || {
^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -e "$bf" ] || {
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 117:
cp $1 $bf || warning "$0: failed to copy '$1' to '$bf'"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cp "$1" "$bf" || warning "$0: failed to copy '$1' to '$bf'"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 118:
chmod a-w $bf || warning "$0: failed to chmod '$bf'"
^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod a-w "$bf" || warning "$0: failed to chmod '$bf'"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 121:
rm $1 || warning "$0: failed to remove '$1'"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm "$1" || warning "$0: failed to remove '$1'"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 124:
chmod a-w $1 || warning "$0: failed to chmod '$1'"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod a-w "$1" || warning "$0: failed to chmod '$1'"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 134:
local first_conf= second_conf=
^---------------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^-- SC1007 (warning): Remove space after = if trying to assign a value (for empty string, use var='' ... ).
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 135:
[ $# -eq 2 ] && [ "$1" ] && [ "$2" ] ||
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 137:
[ -f $1 ] && [ -f $2 ] ||
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -f "$1" ] && [ -f "$2" ] ||
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 141:
set -- $(md5sum $first_conf $second_conf 2>/dev/null || :)
^-- SC2046 (warning): Quote this to prevent word splitting.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
set -- $(md5sum "$first_conf" "$second_conf" 2>/dev/null || :)
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 143:
[ $1 = $3 ]
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$1" = "$3" ]
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 175:
readonly base_cf=$conf_dir/base/$hwid.conf
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
readonly base_cf=$conf_dir/base/"$hwid".conf
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 177:
[ ! -f $base_cf ] || file=$base_cf
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -f "$base_cf" ] || file=$base_cf
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 178:
cp -pf $file $backup_file_tmp
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cp -pf "$file" $backup_file_tmp
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 192:
get_config $newcf $optics new_ctrl new_len new_nl new_ifm
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
get_config $newcf "$optics" new_ctrl new_len new_nl new_ifm
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 199:
[ "$new_len" ] && [ "$new_nl" ] && [ "$new_ifm" ] ||
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 203:
get_config $backup_file $optics old_ctrl old_len old_nl old_ifm
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
get_config $backup_file "$optics" old_ctrl old_len old_nl old_ifm
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 205:
[ "$old_len" ] && [ "$old_nl" ] && [ "$old_ifm" ] ||
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 212:
[ $old_len -ne $new_len ] ||
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$old_len" -ne "$new_len" ] ||
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 213:
[ $old_nl -ne $new_nl ] ||
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$old_nl" -ne "$new_nl" ] ||
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 214:
[ $old_ifm -ne $new_ifm ] || {
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$old_ifm" -ne "$new_ifm" ] || {
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 223:
[ $STD2_MECHANICS_FOCUS_MOTORPOSITION -eq -1 ] || {
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$STD2_MECHANICS_FOCUS_MOTORPOSITION" -eq -1 ] || {
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 224:
adjust_focus val $STD2_MECHANICS_FOCUS_MOTORPOSITION $old_nl $new_nl $new_len
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
adjust_focus val "$STD2_MECHANICS_FOCUS_MOTORPOSITION" "$old_nl" "$new_nl" "$new_len"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 225:
sed -i "/[[]Mechanics.Focus[]]/,/MotorPosition=.*/ s/MotorPosition=.*/MotorPosition=$val/" $state_file_tmp || {
^--^ SC2154 (warning): val is referenced but not assigned (for output from commands, use "$(val ...)" ).
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 236:
[ $STD2_MECHANICS_FOCUS_LUPOSITION -eq -1 ] || {
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$STD2_MECHANICS_FOCUS_LUPOSITION" -eq -1 ] || {
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 237:
adjust_focus lupf $STD2_MECHANICS_FOCUS_LUPOSITION $old_nl $new_nl $new_len
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
adjust_focus lupf "$STD2_MECHANICS_FOCUS_LUPOSITION" "$old_nl" "$new_nl" "$new_len"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 238:
sed -i "/[[]Mechanics.Focus[]]/,/LUPosition=.*/ s/LUPosition=.*/LUPosition=$lupf/" $fcf_tmp || {
^---^ SC2154 (warning): lupf is referenced but not assigned.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 248:
adjust_float new_pos_f $STD2_IMAGESOURCE_I0_FOCUS_POS $old_len $old_nl $new_len $new_nl
^----------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
adjust_float new_pos_f "$STD2_IMAGESOURCE_I0_FOCUS_POS" "$old_len" "$old_nl" "$new_len" "$new_nl"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/libexec/focusd-fix-focus line 249:
sed -i "/[[]ImageSource.I0.Focus[]]/,/Pos=.*/ s/Pos=.*/Pos=$new_pos_f/" $sffile ||
^--------^ SC2154 (warning): new_pos_f is referenced but not assigned.
For more information:
https://www.shellcheck.net/wiki/SC1007 -- Remove space after = if trying to...
https://www.shellcheck.net/wiki/SC2034 -- cfg_l appears unused. Verify use ...
https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
