In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/addon-list line 5:
. /usr/lib/addon-common
^-------------------^ SC1091 (info): Not following: /usr/lib/addon-common was not specified as input (see shellcheck -x).
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/addon-list line 8:
local script_name=${0##*/}
^---------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
local script_name="${0##*/}"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/addon-list line 22:
local status
^----------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/addon-list line 26:
status=$(systemctl is-active ${1%%[[:blank:]]*}.service) || :
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
status=$(systemctl is-active "${1%%[[:blank:]]*}".service) || :
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/addon-list line 31:
if [ $status = unknown ]; then
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$status" = unknown ]; then
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/addon-list line 34:
echo $status
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$status"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/addon-list line 52:
shift $(($OPTIND - 1))
^-----^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/addon-list line 55:
is_package_name_valid "$1" result || fail_errorcode $ERR_INVALID_PKG_NAME "Failed to validate package name: $1"
^-------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
is_package_name_valid "$1" result || fail_errorcode "$ERR_INVALID_PKG_NAME" "Failed to validate package name: $1"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/addon-list line 57:
[ $result -eq $TRUE ] || fail_errorcode $ERR_INVALID_PKG_NAME "Package name $1 contains illegal characters only " "[a-z0-9.+-] is allowed"
^-----^ SC2154 (warning): result is referenced but not assigned.
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$result" -eq "$TRUE" ] || fail_errorcode "$ERR_INVALID_PKG_NAME" "Package name $1 contains illegal characters only " "[a-z0-9.+-] is allowed"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/addon-list line 67:
echo $pkg - $(get_status $pkg)
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----------------^ SC2046 (warning): Quote this to prevent word splitting.
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$pkg" - $(get_status "$pkg")
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/addon-list line 72:
echo ${pkg%%[[:blank:]]*}
^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "${pkg%%[[:blank:]]*}"
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/addon-list line 78:
echo $pkg - $(get_status $pkg)
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----------------^ SC2046 (warning): Quote this to prevent word splitting.
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$pkg" - $(get_status "$pkg")
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/addon-list line 81:
$1)
^-- SC2254 (warning): Quote expansions in case patterns to match literally rather than as a glob.
In /logs/firmware/unblob_extracted/firmware_extract/4325012-58052244.squashfs_v4_le_extract/usr/bin/addon-list line 82:
echo $pkg - $(get_status $pkg)
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----------------^ SC2046 (warning): Quote this to prevent word splitting.
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$pkg" - $(get_status "$pkg")
For more information:
https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
https://www.shellcheck.net/wiki/SC2154 -- result is referenced but not assi...
https://www.shellcheck.net/wiki/SC2254 -- Quote expansions in case patterns...
