In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/sa/sa2 line 9:
prefix=/usr
^----^ SC2034 (warning): prefix appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/sa/sa2 line 10:
exec_prefix=/usr
^---------^ SC2034 (warning): exec_prefix appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/sa/sa2 line 22:
[ -r ${SYSCONFIG_DIR}/${SYSCONFIG_FILE} ] && . ${SYSCONFIG_DIR}/${SYSCONFIG_FILE}
^-- SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/sa/sa2 line 30:
DELAY=$((${RANDOM}%${DELAY_RANGE}))
^-------^ SC3028 (warning): In POSIX sh, RANDOM is undefined.
^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
^------------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/sa/sa2 line 37:
if [ x$YESTERDAY = xno ]
^---------^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$YESTERDAY" = no ]
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/sa/sa2 line 46:
DATE=`date ${DATE_OPTS} +%Y%m%d`
^-------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
DATE=$(date ${DATE_OPTS} +%Y%m%d)
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/sa/sa2 line 48:
DATE=`date ${DATE_OPTS} +%d`
^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
DATE=$(date ${DATE_OPTS} +%d)
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/sa/sa2 line 61:
cd ${ENDIR}
^---------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
Did you mean:
cd ${ENDIR} || exit
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/sa/sa2 line 62:
if [ x${REPORTS} != xfalse ]
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ x"${REPORTS}" != xfalse ]
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/sa/sa2 line 64:
${ENDIR}/sar $* -f ${DFILE} > ${RPT}
^-- SC2048 (warning): Use "$@" (with quotes) to prevent whitespace problems.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
${ENDIR}/sar "$*" -f "${DFILE}" > "${RPT}"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/sa/sa2 line 70:
| egrep "${SAFILES_REGEX}" \
^---^ SC2196 (info): egrep is non-standard and deprecated. Use grep -E instead.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/sa/sa2 line 76:
| egrep "${UNCOMPRESSED_SAFILES_REGEX}" \
^---^ SC2196 (info): egrep is non-standard and deprecated. Use grep -E instead.
For more information:
https://www.shellcheck.net/wiki/SC1090 -- ShellCheck can't follow non-const...
https://www.shellcheck.net/wiki/SC2034 -- exec_prefix appears unused. Verif...
https://www.shellcheck.net/wiki/SC2048 -- Use "$@" (with quotes) to prevent...
