In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 8:
. /lib/rcscripts/sh/files.sh
^------------------------^ SC1091 (info): Not following: /lib/rcscripts/sh/files.sh was not specified as input (see shellcheck -x).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 21:
if [ -f $1$pre_8_10_cf ] && [ -r $1$pre_8_10_cf ] &&
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -f "$1"$pre_8_10_cf ] && [ -r "$1"$pre_8_10_cf ] &&
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 22:
[ $(stat -c %U $1$pre_8_10_cf) = root ]; then
^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ $(stat -c %U "$1"$pre_8_10_cf) = root ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 23:
. $1$pre_8_10_cf
^------------^ SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
. "$1"$pre_8_10_cf
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 30:
if [ -f $1$netd_cf ] && [ -r $1$netd_cf ] &&
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -f "$1"$netd_cf ] && [ -r "$1"$netd_cf ] &&
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 31:
[ $(stat -c %U $1$netd_cf) = root ]; then
^----------------------^ SC2046 (warning): Quote this to prevent word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ $(stat -c %U "$1"$netd_cf) = root ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 32:
tmp=$(sed -ne 's/^TimeSyncSource=//p' $1$netd_cf)
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tmp=$(sed -ne 's/^TimeSyncSource=//p' "$1"$netd_cf)
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 34:
tmp=$(sed -ne 's/^UseDHCPNTPServers=//p' $1$netd_cf)
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tmp=$(sed -ne 's/^UseDHCPNTPServers=//p' "$1"$netd_cf)
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 36:
tmp=$(sed -ne 's/^StaticNTPServer=//p' $1$netd_cf)
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tmp=$(sed -ne 's/^StaticNTPServer=//p' "$1"$netd_cf)
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 42:
if [ -z $ss_value ] && [ -z $obtain_value ] && [ -z $server_value ]; then
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -z "$ss_value" ] && [ -z "$obtain_value" ] && [ -z "$server_value" ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 43:
if [ -f $1$ntpconfd_cf ] && [ -r $1$ntpconfd_cf ] &&
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -f "$1"$ntpconfd_cf ] && [ -r "$1"$ntpconfd_cf ] &&
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 44:
[ $(stat -c %U $1$ntpconfd_cf) = ntpconfd ]; then
^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ $(stat -c %U "$1"$ntpconfd_cf) = ntpconfd ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 45:
cp -f $1$ntpconfd_cf $ntpconfd_cf ||
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cp -f "$1"$ntpconfd_cf $ntpconfd_cf ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 103:
if [ -f $1$ntpconfd_cf ] && [ -r $1$ntpconfd_cf ]; then
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -f "$1"$ntpconfd_cf ] && [ -r "$1"$ntpconfd_cf ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 104:
while read key value; do
^--^ SC2162 (info): read without -r will mangle backslashes.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 113:
done <$1$ntpconfd_cf
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
done <"$1"$ntpconfd_cf
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 126:
[ -z "$server_value" ] || echo StaticServers $server_value >&9 ||
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -z "$server_value" ] || echo StaticServers "$server_value" >&9 ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 128:
[ -z "$server_enable_value" ] || echo ServerEnabled $server_enable_value >&9 ||
^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -z "$server_enable_value" ] || echo ServerEnabled "$server_enable_value" >&9 ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/conf-migrate/upgrade-run.d/ntpconfd line 131:
echo ServerFudgeModeEnabled $server_fudge_value >&9 ||
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo ServerFudgeModeEnabled "$server_fudge_value" >&9 ||
For more information:
https://www.shellcheck.net/wiki/SC1090 -- ShellCheck can't follow non-const...
https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
https://www.shellcheck.net/wiki/SC1091 -- Not following: /lib/rcscripts/sh/...
