In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 3:
. /lib/rcscripts/sh/error.sh
^------------------------^ SC1091 (info): Not following: /lib/rcscripts/sh/error.sh was not specified as input (see shellcheck -x).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 6:
. $conf || error "Failed to source '$conf'!"
^---^ SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 11:
read DEFAULT_QDISC </proc/sys/net/core/default_qdisc
^--^ SC2162 (info): read without -r will mangle backslashes.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 19:
mtu=$(ip -o link show $iface)
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mtu=$(ip -o link show "$iface")
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 29:
local mtu roundup flow_limit
^--------------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 40:
WMEM_MAX=$(($WMEM_MAX * 2))
^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 43:
eval mtu=\$MTU_$1
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval mtu=\$MTU_"$1"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 46:
flow_limit=$(($WMEM_MAX / $mtu))
^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 47:
flow_limit=$(((($flow_limit / $roundup) + 1) * $roundup))
^---------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
^------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
^------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 53:
local iface
^---------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 58:
get_default_qdisc_opts $iface
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
get_default_qdisc_opts "$iface"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 59:
tc qdisc replace dev $iface root $DEFAULT_QDISC $DEFAULT_QDISC_OPTS || return 1
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tc qdisc replace dev "$iface" root "$DEFAULT_QDISC" "$DEFAULT_QDISC_OPTS" || return 1
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 64:
local tc_burst=
^------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 68:
eval tc_burst=\$MTU_$1
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval tc_burst=\$MTU_"$1"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 69:
tc_burst=$(($tc_burst + 100))
^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 71:
if [ $TC_BURST -gt $tc_burst ]; then
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------^ SC2153 (info): Possible misspelling: TC_BURST may not be assigned. Did you mean tc_burst?
Did you mean:
if [ "$TC_BURST" -gt $tc_burst ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 75:
[ $tc_burst -gt 0 ] || error "No valid burst value"
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$tc_burst" -gt 0 ] || error "No valid burst value"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 77:
tc qdisc del dev $1 root 2>/dev/null || :
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tc qdisc del dev "$1" root 2>/dev/null || :
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 79:
tc qdisc add dev $1 root handle 1: htb default 10 || return 1
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tc qdisc add dev "$1" root handle 1: htb default 10 || return 1
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 81:
tc class add dev $1 parent 1: classid 1:1 htb rate $TC_RATE || return 1
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tc class add dev "$1" parent 1: classid 1:1 htb rate "$TC_RATE" || return 1
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 83:
tc class add dev $1 parent 1:1 classid 1:10 htb rate 1kbit ceil $TC_RATE\
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tc class add dev "$1" parent 1:1 classid 1:10 htb rate 1kbit ceil "$TC_RATE"\
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 85:
tc qdisc add dev $1 parent 1:10 handle 100: tbf rate $TC_RATE burst $tc_burst\
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tc qdisc add dev "$1" parent 1:10 handle 100: tbf rate "$TC_RATE" burst "$tc_burst"\
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 89:
get_default_qdisc_opts $1
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
get_default_qdisc_opts "$1"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 90:
tc qdisc add dev $1 parent 100:1 $DEFAULT_QDISC $DEFAULT_QDISC_OPTS || return 1
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tc qdisc add dev "$1" parent 100:1 "$DEFAULT_QDISC" "$DEFAULT_QDISC_OPTS" || return 1
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 94:
tc class add dev $1 parent 1:1 classid 1:20 htb rate 1kbit ceil $TC_RATE \
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tc class add dev "$1" parent 1:1 classid 1:20 htb rate 1kbit ceil "$TC_RATE" \
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 96:
tc qdisc add dev $1 parent 1:20 tbf rate $TC_RATE burst $tc_burst latency 1s \
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tc qdisc add dev "$1" parent 1:20 tbf rate "$TC_RATE" burst "$tc_burst" latency 1s \
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 98:
tc filter add dev $1 parent 1: protocol ip prio 0 u32 match ip protocol 17 \
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tc filter add dev "$1" parent 1: protocol ip prio 0 u32 match ip protocol 17 \
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 105:
local rate rate_unit iface changed
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 108:
rate_unit=${TC_RATE#$rate}
^---^ SC2295 (info): Expansions inside ${..} need to be quoted separately, otherwise they match as patterns.
Did you mean:
rate_unit=${TC_RATE#"$rate"}
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 113:
if [ $rate -ge $LOWER_LIMIT_KBIT ] &&
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$rate" -ge "$LOWER_LIMIT_KBIT" ] &&
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 114:
[ $rate -le $UPPER_LIMIT_KBIT ]; then
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$rate" -le "$UPPER_LIMIT_KBIT" ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 117:
tc_add_cmd $iface || {
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tc_add_cmd "$iface" || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 125:
if [ $rate -ge $LOWER_LIMIT_MBIT ] &&
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$rate" -ge "$LOWER_LIMIT_MBIT" ] &&
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 126:
[ $rate -le $UPPER_LIMIT_MBIT ]; then
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$rate" -le "$UPPER_LIMIT_MBIT" ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 129:
tc_add_cmd $iface || {
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tc_add_cmd "$iface" || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 142:
local iface
^---------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/libexec/bandwidth-setup line 145:
tc qdisc del dev $iface root 2>/dev/null || :
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tc qdisc del dev "$iface" root 2>/dev/null || :
For more information:
https://www.shellcheck.net/wiki/SC1090 -- ShellCheck can't follow non-const...
https://www.shellcheck.net/wiki/SC3043 -- In POSIX sh, 'local' is undefined.
https://www.shellcheck.net/wiki/SC1091 -- Not following: /lib/rcscripts/sh/...
