In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/addon-systemctl line 5:
. /usr/lib/addon-common
^-------------------^ SC1091 (info): Not following: /usr/lib/addon-common was not specified as input (see shellcheck -x).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/addon-systemctl line 7:
[ $# -eq 2 ] && [ "$1" ] && [ "$2" ] || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/addon-systemctl line 27:
is_package_name_valid "$2" result || fail_errorcode $ERR_INVALID_PKG_NAME "Failed to validate package name: $2"
^-------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
is_package_name_valid "$2" result || fail_errorcode "$ERR_INVALID_PKG_NAME" "Failed to validate package name: $2"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/addon-systemctl line 29:
[ $result -eq $TRUE ] || fail_errorcode $ERR_INVALID_PKG_NAME "Package name $2 contains illegal characters only [a-z0-9.+-] is allowed"
^-----^ SC2154 (warning): result is referenced but not assigned.
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$result" -eq "$TRUE" ] || fail_errorcode "$ERR_INVALID_PKG_NAME" "Package name $2 contains illegal characters only [a-z0-9.+-] is allowed"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/addon-systemctl line 32:
if [ ${service%%[[:blank:]]*} = $2 ]; then
^----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "${service%%[[:blank:]]*}" = "$2" ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/addon-systemctl line 33:
if [ $1 = start ]; then
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$1" = start ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/addon-systemctl line 34:
systemctl $option $2 || fail_errorcode $ERR_ADDON_SERVICE "Failed to $option $2"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
systemctl $option "$2" || fail_errorcode "$ERR_ADDON_SERVICE" "Failed to $option $2"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/addon-systemctl line 35:
systemctl $1 $2 || fail_errorcode $ERR_ADDON_SERVICE "Failed to $1 $2"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
systemctl "$1" "$2" || fail_errorcode "$ERR_ADDON_SERVICE" "Failed to $1 $2"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/addon-systemctl line 37:
systemctl $1 $2 || fail_errorcode $ERR_ADDON_SERVICE "Failed to $1 $2"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
systemctl "$1" "$2" || fail_errorcode "$ERR_ADDON_SERVICE" "Failed to $1 $2"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/addon-systemctl line 38:
systemctl $option $2 || fail_errorcode $ERR_ADDON_SERVICE "Failed to $option $2"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
systemctl $option "$2" || fail_errorcode "$ERR_ADDON_SERVICE" "Failed to $option $2"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/addon-systemctl line 40:
save_running_state $2 || fail_errorcode $ERR_ADDON_SERVICE "Failed to save running state of: $2"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
save_running_state "$2" || fail_errorcode "$ERR_ADDON_SERVICE" "Failed to save running state of: $2"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/addon-systemctl line 45:
fail_errorcode $ERR_ADDON_NOT_FOUND "No add-on service found for $2"
^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
fail_errorcode "$ERR_ADDON_NOT_FOUND" "No add-on service found for $2"
For more information:
https://www.shellcheck.net/wiki/SC2154 -- result is referenced but not assi...
https://www.shellcheck.net/wiki/SC1091 -- Not following: /usr/lib/addon-com...
https://www.shellcheck.net/wiki/SC2015 -- Note that A && B || C is not if-t...
