In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 13:
ERR_INSTALL_OPKG=22 # Failed to install the add-on opk
^--------------^ SC2034 (warning): ERR_INSTALL_OPKG appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 15:
ERR_INSTALL_ADDON_USER=24 # Failed create or modify addon user
^--------------------^ SC2034 (warning): ERR_INSTALL_ADDON_USER appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 16:
ERR_PREINSTALL_SKIPPED=25 # Skipped to pre-install the add-on
^--------------------^ SC2034 (warning): ERR_PREINSTALL_SKIPPED appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 17:
ERR_CREATE_FCGI=26 # Failed to create fcgi handler or fcgi access file
^-------------^ SC2034 (warning): ERR_CREATE_FCGI appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 18:
ERR_CREATE_URL=27 # Failed to create url access file
^------------^ SC2034 (warning): ERR_CREATE_URL appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 21:
ERR_FILE_FORMAT=40 # Invalid add-on package file format
^-------------^ SC2034 (warning): ERR_FILE_FORMAT appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 22:
ERR_INVALID_CONTENT=41 # Invalid content in the add-on opk
^-----------------^ SC2034 (warning): ERR_INVALID_CONTENT appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 23:
ERR_NO_SIGNATURE=42 # Add-on package does not contain a signature
^--------------^ SC2034 (warning): ERR_NO_SIGNATURE appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 24:
ERR_BAD_SIGNATURE=43 # The signature in the add-on package is invalid
^---------------^ SC2034 (warning): ERR_BAD_SIGNATURE appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 25:
ERR_MANIFEST=44 # Invalid manifest
^----------^ SC2034 (warning): ERR_MANIFEST appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 26:
ERR_NO_LICENSE=45 # Add-on manifest does not contain a license
^------------^ SC2034 (warning): ERR_NO_LICENSE appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 27:
ERR_NO_PACKAGE_CONFIG=46 # Add-On package does not contain a package config
^-------------------^ SC2034 (warning): ERR_NO_PACKAGE_CONFIG appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 28:
ERR_INVALID_PACKAGE_CONFIG=47 # Invalid package config
^------------------------^ SC2034 (warning): ERR_INVALID_PACKAGE_CONFIG appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 29:
ERR_UNSUPPORTED_SIGNATURE_FORMAT=48 # Unsupported signature format
^-- SC2034 (warning): ERR_UNSUPPORTED_SIGNATURE_FORMAT appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 30:
ERR_UNSUPPORTED_PACKAGE_FORMAT=49 # Unsupported package format
^----------------------------^ SC2034 (warning): ERR_UNSUPPORTED_PACKAGE_FORMAT appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 31:
ERR_INVALID_PKG_NAME=50 # Invalid package name
^------------------^ SC2034 (warning): ERR_INVALID_PKG_NAME appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 34:
ERR_INVALID_REQUIREMENT=60 # Invalid requirement in the add-on manifest
^---------------------^ SC2034 (warning): ERR_INVALID_REQUIREMENT appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 35:
ERR_API_GRANT_FAILED=61 # Failed to grant access to API
^------------------^ SC2034 (warning): ERR_API_GRANT_FAILED appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 36:
ERR_ARCHITECTURE=62 # Incompatible architecture specified in add-on manifest
^--------------^ SC2034 (warning): ERR_ARCHITECTURE appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 40:
ERR_ADDON_SERVICE=71 # Add-on service error
^---------------^ SC2034 (warning): ERR_ADDON_SERVICE appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 44:
ERR_LOWER_VERSION=80 # Failed to install add-on with lower version than the
^---------------^ SC2034 (warning): ERR_LOWER_VERSION appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 54:
DEVMODE_ALLOW_ALL_VALUE='*'
^---------------------^ SC2034 (warning): DEVMODE_ALLOW_ALL_VALUE appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 63:
local errorcode=$1
^-------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
local errorcode="$1"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 66:
exit $errorcode
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
exit "$errorcode"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 77:
local logtag
^----------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 78:
local severity
^------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 137:
. /lib/rcscripts/sh/string.sh
^-------------------------^ SC1091 (info): Not following: /lib/rcscripts/sh/string.sh was not specified as input (see shellcheck -x).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 138:
. /lib/rcscripts/sh/files.sh
^------------------------^ SC1091 (info): Not following: /lib/rcscripts/sh/files.sh was not specified as input (see shellcheck -x).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 144:
local tmp_addon_dir="/tmp/addon"
^-----------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 145:
local finalize_file="$tmp_addon_dir/finalize"
^-----------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 184:
WEB_DOCUMENT_ROOT=/usr/html
^---------------^ SC2034 (warning): WEB_DOCUMENT_ROOT appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 258:
[ $1 ] || {
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$1" ] || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 262:
[ -d /opt/$1 ] || revert_and_fail $ERR_INSTALL_ERROR "Package $1 is installed but the folder does not exist"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -d /opt/"$1" ] || revert_and_fail $ERR_INSTALL_ERROR "Package $1 is installed but the folder does not exist"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 263:
systemctl is-active $1 > /opt/$1/saved_states.tmp || :
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
systemctl is-active "$1" > /opt/"$1"/saved_states.tmp || :
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 264:
fsynced_write_or_cleanup /opt/$1/saved_states.tmp /opt/$1/saved_states
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
fsynced_write_or_cleanup /opt/"$1"/saved_states.tmp /opt/"$1"/saved_states
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 276:
local num_words
^-------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 282:
[ $1 ] || {
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$1" ] || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 286:
[ -d /opt/$1 ] || revert_and_fail $ERR_ADDON_NOT_FOUND "No installation folder for package $1"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -d /opt/"$1" ] || revert_and_fail $ERR_ADDON_NOT_FOUND "No installation folder for package $1"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 288:
if [ -f /opt/$1/saved_states ]; then
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -f /opt/"$1"/saved_states ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 289:
num_words=$(wc -w < /opt/$1/saved_states)
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
num_words=$(wc -w < /opt/"$1"/saved_states)
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 291:
if [ $num_words -ne 1 ]; then
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$num_words" -ne 1 ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 295:
read old_state < /opt/$1/saved_states
^--^ SC2162 (info): read without -r will mangle backslashes.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
read old_state < /opt/"$1"/saved_states
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 298:
if [ $2 ]; then
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$2" ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 301:
echo $1 > $2.tmp || syslog_warn $COMMON_LOG_TAG "Restore running state: Failed to write to $2.tmp"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$1" > "$2".tmp || syslog_warn $COMMON_LOG_TAG "Restore running state: Failed to write to $2.tmp"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 302:
[ ! -f $2 ] || {
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -f "$2" ] || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 303:
cat $2 >> $2.tmp || syslog_warn $COMMON_LOG_TAG "Restore running state: Failed to append to $2.tmp"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cat "$2" >> "$2".tmp || syslog_warn $COMMON_LOG_TAG "Restore running state: Failed to append to $2.tmp"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 312:
addon-systemctl start $1 > /dev/null 2>&1 || {
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
addon-systemctl start "$1" > /dev/null 2>&1 || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 343:
local _result
^-----------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 360:
ar -p $1 control* | tar -zt | egrep "pre|post"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^---^ SC2196 (info): egrep is non-standard and deprecated. Use grep -E instead.
Did you mean:
ar -p "$1" control* | tar -zt | egrep "pre|post"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 364:
if [ $? -eq 0 ]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 370:
eval $2=\$_result
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$2"=\$_result
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 387:
local _result
^-----------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 411:
eval $2=\$_result
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$2"=\$_result
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 439:
local tmp_file=$PREINSTALL_BLACKLIST_FILE.tmp
^------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 480:
local _result
^-----------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 504:
eval $2=\$_result
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$2"=\$_result
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 523:
local _result
^-----------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 540:
OPKGSTATUS=$($OPKG status $1) || {
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
OPKGSTATUS=$($OPKG status "$1") || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 552:
eval $2=\$_result
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$2"=\$_result
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 564:
local _allowed_apis
^-----------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 570:
echo $_allowed_apis
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$_allowed_apis"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 587:
local _api
^--------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 639:
local _result _user major
^-----------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 666:
if _user=$(addon-registry $1 $major $2); then
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if _user=$(addon-registry "$1" $major "$2"); then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 672:
eval $3=\$_result
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$3"=\$_result
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 673:
eval $4=\$_user
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$4"=\$_user
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 689:
local filename
^------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 691:
[ $# -eq 1 ] && [ "$1" ] || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 719:
[ $# -eq 2 ] && [ "$1" ] && validate_varname $2 || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ $# -eq 2 ] && [ "$1" ] && validate_varname "$2" || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 724:
local _version
^------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 727:
_version=$(xmllint --xpath 'string(//PackageInfo/Version)' $1) ||
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
_version=$(xmllint --xpath 'string(//PackageInfo/Version)' "$1") ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 736:
eval $2=\$_version
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$2"=\$_version
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 753:
[ $# -eq 2 ] && [ "$1" ] && validate_varname $2 || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ $# -eq 2 ] && [ "$1" ] && validate_varname "$2" || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 758:
local _major_version
^------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 761:
_major_version=$(xmllint --xpath 'string(//Manifest/@Major)' $1) ||
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
_major_version=$(xmllint --xpath 'string(//Manifest/@Major)' "$1") ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 769:
eval $2=\$_major_version
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$2"=\$_major_version
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 785:
local version
^-----------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 787:
[ $# -eq 1 ] && [ "$1" ] || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 792:
version=$($OPKG info $1 | sed -n 's/Version:[[:blank:]]*\(.*\)/\1/p') || {
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
version=$($OPKG info "$1" | sed -n 's/Version:[[:blank:]]*\(.*\)/\1/p') || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 797:
echo $version
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$version"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 814:
[ $# -ge 1 ] && [ "$1" ] || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 819:
if [ ! -d $LOCK_PATH ]; then
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ ! -d "$LOCK_PATH" ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 820:
mkdir -p $LOCK_PATH
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mkdir -p "$LOCK_PATH"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 823:
local lock_file
^-------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 826:
touch $lock_file || {
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
touch "$lock_file" || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 838:
readlink -f $file >> $lock_file || :
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
readlink -f "$file" >> "$lock_file" || :
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 845:
syncfile $lock_file || {
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
syncfile "$lock_file" || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 859:
local addon_rewrite_conf_file rewrites_symlink
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 861:
[ $# -eq 1 ] && [ "$1" ] || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 869:
[ ! -w $REWRITES_CONF_DIR ] || [ ! -f $addon_rewrite_conf_file ] || {
^----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -w $REWRITES_CONF_DIR ] || [ ! -f "$addon_rewrite_conf_file" ] || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 875:
ln -s $addon_rewrite_conf_file $REWRITES_CONF_DIR || syslog_err $COMMON_LOG_TAG "Could not create a symlink: $addon_rewrite_conf_file"
^----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
ln -s "$addon_rewrite_conf_file" $REWRITES_CONF_DIR || syslog_err $COMMON_LOG_TAG "Could not create a symlink: $addon_rewrite_conf_file"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 881:
[ ! -w $REWRITES_CONF_DIR ] || [ ! -f $addon_rewrite_conf_file ] || {
^----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -w $REWRITES_CONF_DIR ] || [ ! -f "$addon_rewrite_conf_file" ] || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 884:
[ ! -f $rewrites_symlink ] ||
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -f "$rewrites_symlink" ] ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 885:
rm -f $rewrites_symlink
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "$rewrites_symlink"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 887:
ln -s $addon_rewrite_conf_file $REWRITES_CONF_DIR || syslog_err $COMMON_LOG_TAG "Could not create a symlink: $addon_rewrite_conf_file"
^----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
ln -s "$addon_rewrite_conf_file" $REWRITES_CONF_DIR || syslog_err $COMMON_LOG_TAG "Could not create a symlink: $addon_rewrite_conf_file"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 898:
local rewrites_webroot_link addon_rewrite_conf_path link_path file
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
^-------------------^ SC2034 (warning): rewrites_webroot_link appears unused. Verify use (or export if used externally).
^-------^ SC2034 (warning): link_path appears unused. Verify use (or export if used externally).
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 900:
[ $# -eq 1 ] && [ "$1" ] || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 904:
addon_rewrite_conf_path=$OPKG_DEST/$1/usr/conf/*
^----------------------^ SC2125 (warning): Brace expansions and globs are literal in assignments. Quote it or use an array.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 909:
[ -f $file ] || continue
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -f "$file" ] || continue
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 911:
[ ! -f $REWRITES_CONF_DIR/${file##*/} ] ||
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -f $REWRITES_CONF_DIR/"${file##*/}" ] ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 912:
rm -rf $REWRITES_CONF_DIR/${file##*/}
^----------------------------^ SC2115 (warning): Use "${var:?}" to ensure this never expands to / .
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -rf $REWRITES_CONF_DIR/"${file##*/}"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 926:
[ $# -eq 1 ] && [ "$1" ] || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 944:
local result
^----------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 946:
[ $# -eq 1 ] && [ "$1" ] || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 951:
is_package_installed $1 result || {
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
is_package_installed "$1" result || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 956:
[ $result -eq $TRUE ] || {
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$result" -eq $TRUE ] || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 961:
$OPKG remove $1 > /dev/null 2>&1 || {
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
$OPKG remove "$1" > /dev/null 2>&1 || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 973:
local layer refdir
^----------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 975:
[ $# -eq 1 ] && [ "$1" ] || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 981:
if [ -f $layer/lower ]; then
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -f "$layer"/lower ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 983:
[ -r $layer/lower ] ||
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -r "$layer"/lower ] ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 985:
read lowerlayer <$layer/lower
^--^ SC2162 (info): read without -r will mangle backslashes.
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
read lowerlayer <"$layer"/lower
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 989:
refdir=$lowerlayer/ref/*
^---------------^ SC2125 (warning): Brace expansions and globs are literal in assignments. Quote it or use an array.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 990:
[ "$(echo $refdir)" != "$refdir" ] || remove_layer $lowerlayer
^-------------^ SC2116 (style): Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'.
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ "$(echo "$refdir")" != "$refdir" ] || remove_layer "$lowerlayer"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 992:
rm -r $layer
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -r "$layer"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1005:
local addon_path
^--------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1007:
[ $# -eq 1 ] && [ "$1" ] || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1014:
if [ -f $addon_path/.layered ]; then
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -f "$addon_path"/.layered ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1015:
[ -r $addon_path/.layered ] ||
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ -r "$addon_path"/.layered ] ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1017:
read upperlayer <$addon_path/.layered
^--^ SC2162 (info): read without -r will mangle backslashes.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
read upperlayer <"$addon_path"/.layered
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1018:
umount $addon_path
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
umount "$addon_path"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1019:
remove_layer $upperlayer
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
remove_layer "$upperlayer"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1024:
if [ -d $addon_path ]; then
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -d "$addon_path" ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1025:
rm -rf $addon_path || syslog_err $COMMON_LOG_TAG "remove_addon_folder: Failed to remove $addon_path"
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -rf "$addon_path" || syslog_err $COMMON_LOG_TAG "remove_addon_folder: Failed to remove $addon_path"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1039:
local addon_web_link_path
^-----------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1041:
[ $# -eq 1 ] && [ "$1" ] || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1049:
rm -f $addon_web_link_path ||
^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "$addon_web_link_path" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1065:
local alias_conf_file
^-------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1067:
[ $# -eq 1 ] && [ "$1" ] || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1075:
rm $alias_conf_file || syslog_err $COMMON_LOG_TAG "remove_addon_url_alias: Failed to remove alias file"
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm "$alias_conf_file" || syslog_err $COMMON_LOG_TAG "remove_addon_url_alias: Failed to remove alias file"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1089:
local servicefile dropdownfolder dropdownfile
^-- SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1091:
[ $# -eq 1 ] && [ "$1" ] || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1098:
if systemctl -q is-active $1 > /dev/null 2>&; then
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if systemctl -q is-active "$1" > /dev/null 2>&; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1103:
systemctl stop $1 > /dev/null 2>&
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
systemctl stop "$1" > /dev/null 2>&1
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1106:
if systemctl is-enabled $1 > /dev/null 2>&; then
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if systemctl is-enabled "$1" > /dev/null 2>&; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1107:
systemctl disable $1 > /dev/null 2>&
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
systemctl disable "$1" > /dev/null 2>&1
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1110:
systemctl reset-failed $1 > /dev/null 2>&1 || :
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
systemctl reset-failed "$1" > /dev/null 2>&1 || :
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1111:
rm -f $servicefile || syslog_err $COMMON_LOG_TAG "remove_service: Failed to remove service for $1"
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "$servicefile" || syslog_err $COMMON_LOG_TAG "remove_service: Failed to remove service for $1"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1114:
if [ -d $dropdownfolder ]; then
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -d "$dropdownfolder" ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1117:
rm -f $dropdownfile
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "$dropdownfile"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1118:
rmdir $dropdownfolder || syslog_err $COMMON_LOG_TAG "remove_service: Failed to remove service dropdown folder for $1"
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rmdir "$dropdownfolder" || syslog_err $COMMON_LOG_TAG "remove_service: Failed to remove service dropdown folder for $1"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1133:
[ $# -eq 1 ] && [ "$1" ] || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1138:
rm -f $MANIFEST_PATH/${1}_manifest.xml ||
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f $MANIFEST_PATH/"${1}"_manifest.xml ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1152:
[ $# -eq 1 ] && [ "$1" ] || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1157:
apac-update revoke-all $1 || {
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
apac-update revoke-all "$1" || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1174:
[ $# -eq 1 ] && [ "$1" ] || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1198:
local IFS=" "
^-------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1199:
gdbus call -y -d com.axis.PolicyKitSystem -o /com/axis/PolicyKitSystem -m com.axis.PolicyKitSystem."$@"
^-- SC2145 (error): Argument mixes string and array. Use * or separate argument.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1235:
[ $# -eq 2 ] && [ "$1" ] || {
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1244:
tempvar=$(_call_policykit_dbus_method ClearUserFields $1 false true false)
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tempvar=$(_call_policykit_dbus_method ClearUserFields "$1" false true false)
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1248:
tempvar=$(_call_policykit_dbus_method ModifyUser $1 "" "" "[$2]" /bin/false "User for addon $1")
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tempvar=$(_call_policykit_dbus_method ModifyUser "$1" "" "" "[$2]" /bin/false "User for addon $1")
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1267:
local user_id
^-----------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1292:
eval $2=\$_result
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$2"=\$_result
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1308:
local _conf_file _busname
^-----------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1337:
if [ -f $_conf_file.tmp ]; then
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -f "$_conf_file".tmp ]; then
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1338:
rm -f $_conf_file.tmp
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "$_conf_file".tmp
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1368:
</busconfig>" >$_conf_file.tmp
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
</busconfig>" >"$_conf_file".tmp
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1372:
fsynced_write_or_cleanup $_conf_file.tmp $_conf_file
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
fsynced_write_or_cleanup "$_conf_file".tmp "$_conf_file"
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1383:
local _conffolder _cmd _reload=0
^----------------------------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1392:
[ ! -d $_conffolder ] || {
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
[ ! -d "$_conffolder" ] || {
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1393:
files=$(ls -A $_conffolder)
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
files=$(ls -A "$_conffolder")
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1397:
chmod 644 $_conffolder$file ||
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod 644 "$_conffolder""$file" ||
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1427:
rm -f /etc/dbus-1/system.d/$1*
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f /etc/dbus-1/system.d/"$1"*
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/lib/addon-common line 1432:
if [ $FIRST_BOOT_MODE ]; then
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$FIRST_BOOT_MODE" ]; then
For more information:
https://www.shellcheck.net/wiki/SC2145 -- Argument mixes string and array. ...
https://www.shellcheck.net/wiki/SC2034 -- DEVMODE_ALLOW_ALL_VALUE appears u...
https://www.shellcheck.net/wiki/SC2115 -- Use "${var:?}" to ensure this nev...
