In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/a1601_test.sh line 52:
while [ 1 ]; do
^-- SC2161 (style): Instead of '[ 1 ]', use 'true'.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/a1601_test.sh line 53:
val=$(cat $port/value)
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
val=$(cat "$port"/value)
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/a1601_test.sh line 58:
x=$(($x+1))
^-- SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/a1601_test.sh line 59:
if [ "$x" > 500 ]; then
^-- SC2071 (error): > is for string comparisons. Use -gt instead.
^-- SC3012 (warning): In POSIX sh, lexicographical > is undefined.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/a1601_test.sh line 68:
while [ 1 ]; do
^-- SC2161 (style): Instead of '[ 1 ]', use 'true'.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/a1601_test.sh line 84:
COUNT=$(($COUNT+1))
^----^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
In /logs/firmware/patool_extraction/rootfs.img_unblob_extracted/rootfs.img_extract/0-50593792.squashfs_v4_le_extract/usr/bin/a1601_test.sh line 85:
if [ `expr $COUNT % 100` -eq 0 ]; then
^-----------------^ SC2046 (warning): Quote this to prevent word splitting.
^-----------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]].
Did you mean:
if [ $(expr $COUNT % 100) -eq 0 ]; then
For more information:
https://www.shellcheck.net/wiki/SC2071 -- > is for string comparisons. Use ...
https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
https://www.shellcheck.net/wiki/SC3012 -- In POSIX sh, lexicographical > is...